Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.7.1) #17111

Merged
merged 1 commit into from
Sep 6, 2020

Conversation

rgrinberg
Copy link
Member

Embed build informations inside executable

CHANGES:

@camelus
Copy link
Contributor

camelus commented Sep 3, 2020

Commit: 8250214

A pull request by opam-seasoned @rgrinberg.

☀️ All lint checks passed 8250214
  • These packages passed lint tests: dune-action-plugin.2.7.1, dune-build-info.2.7.1, dune-configurator.2.7.1, dune-glob.2.7.1, dune-private-libs.2.7.1, dune.2.7.1

☀️ Installability check (+6)
  • new installable packages (6): dune.2.7.1 dune-action-plugin.2.7.1 dune-build-info.2.7.1 dune-configurator.2.7.1 dune-glob.2.7.1 dune-private-libs.2.7.1

doc: "https://dune.readthedocs.io/"
bug-reports: "https://github.com/ocaml/dune/issues"
depends: [
"ocaml" {>= "4.03.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like dune-configurator now requires at least OCaml 4.06:

#=== ERROR while compiling dune-configurator.2.7.1 ============================#
# context              2.0.7 | linux/x86_64 | ocaml-base-compiler.4.04.2 | pinned(https://github.com/ocaml/dune/releases/download/2.7.1/dune-2.7.1.tbz)
# path                 ~/.opam/4.04/.opam-switch/build/dune-configurator.2.7.1
# command              ~/.opam/4.04/bin/dune build -p dune-configurator -j 72 @install
# exit-code            1
# env-file             ~/.opam/log/dune-configurator-23-9dee53.env
# output-file          ~/.opam/log/dune-configurator-23-9dee53.out
### output ###
#       ocamlc otherlibs/configurator/src/.configurator.objs/byte/configurator__V1.{cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.04/bin/ocamlc.opt -w -40 -safe-string -g -bin-annot -I otherlibs/configurator/src/.configurator.objs/byte -I otherlibs/configurator/src/.configurator.objs/public_cmi -I /home/opam/.opam/4.04/lib/csexp -I /home/opam/.opam/4.04/lib/result -intf-suffix .ml -no-alias-deps -open Configurator__ -o otherlibs/configurator/src/.configurator.objs/byte/configurator__V1.cmo -c -impl otherlibs/configurator/src/v1.ml)
# File "otherlibs/configurator/src/v1.ml", line 532, characters 13-27:
# Error: Unbound value Int.Map.update
#     ocamlopt otherlibs/configurator/src/.configurator.objs/native/configurator__V1.{cmx,o} (exit 2)
# (cd _build/default && /home/opam/.opam/4.04/bin/ocamlopt.opt -w -40 -safe-string -g -I otherlibs/configurator/src/.configurator.objs/byte -I otherlibs/configurator/src/.configurator.objs/native -I otherlibs/configurator/src/.configurator.objs/public_cmi -I /home/opam/.opam/4.04/lib/csexp -I /home/opam/.opam/4.04/lib/result -intf-suffix .ml -no-alias-deps -open Configurator__ -o otherlibs/configurator/src/.configurator.objs/native/configurator__V1.cmx -c -impl otherlibs/configurator/src/v1.ml)
# File "otherlibs/configurator/src/v1.ml", line 532, characters 13-27:
# Error: Unbound value Int.Map.update

Is that correct?

bug-reports: "https://github.com/ocaml/dune/issues"
depends: [
"ocaml" {>= "4.03.0"}
"dune" {>= "2.7" & >= "2.6.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like an outdated constraint has been left in the dune-project file

…lugin, dune-private-libs and dune-glob (2.7.1)

CHANGES:

- configurator: More flexible probing of `#define`. We allow duplicate values in
  the object file, as long as they are the same after parsing. (ocaml/dune#3739, fixes
  ocaml/dune#3736, @rgrinberg)

- Record instrumentation backends in dune-package files. This makes it possible
  to use instrumentation backends defined in installed libraries (eg via OPAM).
  (ocaml/dune#3735, @nojb)

- Add missing `.aux` & `.glob` targets to coq rules (ocaml/dune#3721, fixes ocaml/dune#3437,
  @rgrinberg)

- Fix `dune-package` installation when META templates are present (ocaml/dune#3743, fixes
  ocaml/dune#3746, @rgrinberg)

- Resolve symlinks before running `$ git diff` (ocaml/dune#3750, fixes ocaml/dune#3740, @rgrinberg)

- Cram tests: when checking that all test directories contain a `run.t` file,
  skip empty directories. These can be left around by git. (ocaml/dune#3753, @emillon)
@kit-ty-kate
Copy link
Member

Thanks a lot!

@kit-ty-kate kit-ty-kate merged commit 3c75023 into ocaml:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison with expected tests using Git diff is broken aux files set-up as read-only
3 participants