Record instrumentation backends in dune-package #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nojb -- tested it locally with modified versions of landmarks and bisect_ppx (pinning them in my opam switch) and all seems to be working. |
|
Thanks for the confirmation @patricoferris! @rgrinberg would it be possible to make a bug fix release with this? |
nojb
force-pushed
the
fix_instrumentation_dune_package
branch
from
1bd44e3 to
09c4581
Compare
|
Sounds good. Could you add a CHANGES entry? |
Thanks, done! |
rgrinberg
approved these changes
Aug 21, 2020
|
Do we have a test for this? If not, I think we should add a test for installed instrumentation backends. See how we do it for inline tests, ppx drivers, or virtual libraries for an example. |
No, we don't.
Will do, thanks. |
nojb
force-pushed
the
fix_instrumentation_dune_package
branch
2 times, most recently
from
cd81c10 to
4c5eccf
Compare
This is now done. |
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
rgrinberg
force-pushed
the
fix_instrumentation_dune_package
branch
from
4c5eccf to
ae15a89
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Sep 3, 2020
…lugin, dune-private-libs and dune-glob (2.7.1) CHANGES: - configurator: More flexible probing of `#define`. We allow duplicate values in the object file, as long as they are the same after parsing. (ocaml/dune#3739, fixes ocaml/dune#3736, @rgrinberg) - Record instrumentation backends in dune-package files. This makes it possible to use instrumentation backends defined in installed libraries (eg via OPAM). (ocaml/dune#3735, @nojb) - Add missing `.aux` & `.glob` targets to coq rules (ocaml/dune#3721, fixes ocaml/dune#3437, @rgrinberg) - Fix `dune-package` installation when META templates are present (ocaml/dune#3743, fixes ocaml/dune#3746, @rgrinberg) - Resolve symlinks before running `$ git diff` (ocaml/dune#3750, fixes ocaml/dune#3740, @rgrinberg) - Cram tests: when checking that all test directories contain a `run.t` file, skip empty directories. These can be left around by git. (ocaml/dune#3753, @emillon)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Sep 5, 2020
…lugin, dune-private-libs and dune-glob (2.7.1) CHANGES: - configurator: More flexible probing of `#define`. We allow duplicate values in the object file, as long as they are the same after parsing. (ocaml/dune#3739, fixes ocaml/dune#3736, @rgrinberg) - Record instrumentation backends in dune-package files. This makes it possible to use instrumentation backends defined in installed libraries (eg via OPAM). (ocaml/dune#3735, @nojb) - Add missing `.aux` & `.glob` targets to coq rules (ocaml/dune#3721, fixes ocaml/dune#3437, @rgrinberg) - Fix `dune-package` installation when META templates are present (ocaml/dune#3743, fixes ocaml/dune#3746, @rgrinberg) - Resolve symlinks before running `$ git diff` (ocaml/dune#3750, fixes ocaml/dune#3740, @rgrinberg) - Cram tests: when checking that all test directories contain a `run.t` file, skip empty directories. These can be left around by git. (ocaml/dune#3753, @emillon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embarrassingly, it seems that
instrumentationbackends are not recorded indune-packagewhich renders the feature unusable across installed libraries (egopam). Bug discovered by @patricoferris.