JOSS paper #83

NoraLoose · 2021-09-01T19:20:17Z

This adds a draft of the JOSS paper. Same as in #76, but with clean git history.

codecov-commenter · 2021-09-01T19:26:50Z

Codecov Report

Merging #83 (93d4a11) into master (5c34245) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files           9        9           
  Lines         944      944           
=======================================
  Hits          932      932           
  Misses         12       12

Flag	Coverage Δ
unittests	`98.72% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c34245...93d4a11. Read the comment docs.

rabernat

Looks great. I have a few comments.

paper.md

- emphasize opportunity to use gcm-filters for observational data - introduce new subsection - incorporate Hemant's comment on atmospheric models - add NSF and NOAA grants to acknowledgments

…into joss-paper

NoraLoose · 2021-11-02T16:08:47Z

Thanks all for your contributions and comments!

Here is an updated version of the JOSS paper. It now includes authorship information and also acknowledges funding sources.

I would like to submit tomorrow morning, so please provide final comments (missing middle initials? missing funding sources?) by tonight if possible.

Authorship order

To determine the authorship order, I used git shortlog to extract a list of the commit counts:

$ git shortlog --summary --numbered --no-merges
   244  NoraLoose
    45  Ryan Abernathey
    43  Ian Grooms
    32  Julius Busecke
    29  Arthur
    13  Elizabeth A Yankovsky
    10  Gustavo Marques
    10  Jake Steinberg
     9  Andrew Ross
     9  Hemant Khatri
     2  Scott Bachman

I hope everyone is happy with this. Please reach out if you are not.

cc: @rabernat @iangrooms @jbusecke @arthurBarthe @ElizabethYankovsky @gustavo-marques @jakesteinberg @asross @hmkhatri @sdbachman @LaureZanna

paper.md

asross · 2021-11-02T20:31:08Z

paper.md

+  - name: Jacob Steinberg
+    orcid: 0000-0002-2609-6405
+    affiliation: 5
+  - name: Andrew Ross


If you could update this to Andrew Slavin Ross, that would be great!

jbusecke

This looks great. Thank you for all the work @NoraLoose.

NoraLoose · 2021-11-05T00:50:57Z

paper.md

+This work was supported by the National Science Foundation grants OCE 1912302, OCE 1912325, OCE 1912332, OCE 1912420, GEO 1912357, and the NOAA grant CVP NA19OAR4310364.
+Busecke received support from the Gordon and Betty Moore Foundation.
+Busecke received support from the Gordon and Betty Moore Foundation.
+


@rabernat, this sentence was already included. Now it's there twice.

Oops, I think I clicked merge on a stale tab! 🤦 I'll remove it.

rabernat

Just did a final read through. Everything looks great. If you agree with these final suggestions, please merge them.

Thanks so much Nora for your hard work on this. You have my approval to submit whenever you're ready.

paper.md

rabernat · 2021-11-05T00:58:42Z

paper.md

+This work was supported by the National Science Foundation grants OCE 1912302, OCE 1912325, OCE 1912332, OCE 1912420, GEO 1912357, and the NOAA grant CVP NA19OAR4310364.
+Busecke received support from the Gordon and Betty Moore Foundation.
+Busecke received support from the Gordon and Betty Moore Foundation.
+


Oops, I think I clicked merge on a stale tab! 🤦 I'll remove it.

Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>

JOSS paper, refs, and plot

4cfa2d5

rabernat reviewed Sep 2, 2021

View reviewed changes

paper.md Outdated Show resolved Hide resolved

paper.md Outdated Show resolved Hide resolved

paper.md Outdated Show resolved Hide resolved

paper.md Outdated Show resolved Hide resolved

NoraLoose added 2 commits September 2, 2021 16:23

Ryan's comments and updated references

6f77b84

Add reference

4dcdfdc

rabernat approved these changes Sep 3, 2021

View reviewed changes

hmkhatri reviewed Sep 4, 2021

View reviewed changes

paper.md Outdated Show resolved Hide resolved

NoraLoose mentioned this pull request Oct 18, 2021

Contribution and authorship #44

Closed

iangrooms reviewed Oct 23, 2021

View reviewed changes

paper.md Show resolved Hide resolved

NoraLoose added 12 commits October 31, 2021 18:25

Add co-authors

c812a45

Shorten title

f399c33

Update Grooms et al. reference

f7efc05

Paper edits

7b8793d

- emphasize opportunity to use gcm-filters for observational data - introduce new subsection - incorporate Hemant's comment on atmospheric models - add NSF and NOAA grants to acknowledgments

Merge branch 'master' of https://github.com/ocean-eddy-cpt/gcm-filters …

c61e3de

…into joss-paper

Merge branch 'master' of https://github.com/ocean-eddy-cpt/gcm-filters …

cf01578

…into joss-paper

Reorder author list

5fc7ab5

Update POP2 and MOM5 references

713c36c

Fix typo in bib file

69bbbdc

Reorganize text in paper

3d0fc18

Fix typo in bib file

4c65907

Add updated pdf version of paper

ac85311

hmkhatri approved these changes Nov 2, 2021

View reviewed changes

rabernat reviewed Nov 2, 2021

View reviewed changes

paper.md Show resolved Hide resolved

asross reviewed Nov 2, 2021

View reviewed changes

Update author names and funding support

a85d141

jbusecke approved these changes Nov 4, 2021

View reviewed changes

NoraLoose and others added 2 commits November 4, 2021 09:24

Update pdf version of paper

0d541c8

Update paper.md

f01c82b

NoraLoose commented Nov 5, 2021

View reviewed changes

rabernat approved these changes Nov 5, 2021

View reviewed changes

NoraLoose and others added 7 commits November 4, 2021 19:07

Update paper.md

b3643f9

Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>

Update paper.md

00872a7

Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>

Update paper.md

398394c

Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>

Update paper.md

3ac87da

Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>

Change package version number in JOSS paper

9784ea0

Fix mini typo

7fdadfb

Update pdf version of paper

93d4a11

NoraLoose merged commit c25ae18 into ocean-eddy-cpt:master Nov 5, 2021

NoraLoose deleted the joss-paper branch November 5, 2021 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JOSS paper #83

JOSS paper #83

NoraLoose commented Sep 1, 2021

codecov-commenter commented Sep 1, 2021 •

edited

Loading

rabernat left a comment

NoraLoose commented Nov 2, 2021 •

edited

Loading

asross Nov 2, 2021

jbusecke left a comment

NoraLoose Nov 5, 2021

rabernat Nov 5, 2021

rabernat left a comment

rabernat Nov 5, 2021

JOSS paper #83

JOSS paper #83

Conversation

NoraLoose commented Sep 1, 2021

codecov-commenter commented Sep 1, 2021 • edited Loading

Codecov Report

rabernat left a comment

Choose a reason for hiding this comment

NoraLoose commented Nov 2, 2021 • edited Loading

Authorship order

asross Nov 2, 2021

Choose a reason for hiding this comment

jbusecke left a comment

Choose a reason for hiding this comment

NoraLoose Nov 5, 2021

Choose a reason for hiding this comment

rabernat Nov 5, 2021

Choose a reason for hiding this comment

rabernat left a comment

Choose a reason for hiding this comment

rabernat Nov 5, 2021

Choose a reason for hiding this comment

codecov-commenter commented Sep 1, 2021 •

edited

Loading

NoraLoose commented Nov 2, 2021 •

edited

Loading