Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Unify backend environment for Unit & Integration tests #210

Merged
merged 20 commits into from
Oct 13, 2023
Merged

[test] Unify backend environment for Unit & Integration tests #210

merged 20 commits into from
Oct 13, 2023

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Sep 11, 2023 •
edited
Loading

Depends on: onflow/cadence#2783
Depends on: onflow/flow-emulator#476

Closes #208
Closes #209

Description

Unifies backend environment for Unit & Integration tests.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

m-Peter
m-Peter commented Sep 11, 2023
View reviewed changes
test/test_framework_test.go Outdated Show resolved Hide resolved
m-Peter
m-Peter commented Sep 11, 2023
View reviewed changes
test/test_runner.go Outdated Show resolved Hide resolved
m-Peter
m-Peter commented Sep 11, 2023
View reviewed changes
test/test_runner.go Outdated Show resolved Hide resolved
m-Peter
m-Peter commented Sep 11, 2023
View reviewed changes
test/test_runner.go Outdated Show resolved Hide resolved
m-Peter
m-Peter commented Sep 11, 2023
View reviewed changes
test/test_runner.go Outdated Show resolved Hide resolved
m-Peter
m-Peter commented Sep 11, 2023
View reviewed changes
test/test_runner.go Outdated Show resolved Hide resolved
@m-Peter m-Peter force-pushed the unit-testing-improvements branch from 71c3a0a to cca7886 Compare September 11, 2023 15:41
SupunS
SupunS reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start/POC! Nice to see its working 👌

I added some more suggestions, but of course, we would have to see the feasibility.

test/test_framework_test.go Outdated Show resolved Hide resolved
test/test_framework_test.go Outdated Show resolved Hide resolved
test/test_framework_test.go Outdated Show resolved Hide resolved
test/test_runner.go Outdated Show resolved Hide resolved
SupunS
SupunS reviewed Sep 11, 2023
View reviewed changes
test/test_runner.go Outdated Show resolved Hide resolved
@m-Peter m-Peter force-pushed the unit-testing-improvements branch 2 times, most recently from 71b3787 to 4af7fca Compare September 19, 2023 09:54
@m-Peter m-Peter mentioned this pull request Sep 20, 2023
Merged
6 tasks
SupunS
SupunS reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! 👏

Left some comments but they are mostly refactoring.

test/emulator_backend.go Outdated Show resolved Hide resolved
test/test_framework_provider.go Outdated Show resolved Hide resolved
test/test_framework_provider.go Outdated Show resolved Hide resolved
test/test_framework_provider.go Outdated Show resolved Hide resolved
test/test_runner.go Outdated Show resolved Hide resolved
test/test_runner.go Outdated Show resolved Hide resolved
test/test_runner.go Outdated Show resolved Hide resolved
test/test_framework_test.go Show resolved Hide resolved
test/test_framework_test.go Show resolved Hide resolved
test/test_framework_test.go Show resolved Hide resolved
@m-Peter
Copy link
Contributor Author

m-Peter commented Sep 27, 2023

I have also removed the custom InjectedCompositeFieldsHandler, now that we fixed the one upstream in Cadence (a5eeb50)

@SupunS SupunS self-assigned this Sep 27, 2023
@SupunS SupunS added the Improvement Technical work without new features, refactoring, improving tests label Sep 27, 2023
@m-Peter m-Peter mentioned this pull request Sep 28, 2023
Open
@SupunS
Copy link
Member

SupunS commented Sep 28, 2023

Both onflow/cadence#2783 and onflow/flow-emulator#476 are now merged. The go.mods can now be updated to use the commits

@m-Peter m-Peter force-pushed the unit-testing-improvements branch from 252a387 to 47ecddd Compare September 29, 2023 06:04
@m-Peter m-Peter force-pushed the unit-testing-improvements branch from 5cf8589 to fda31d8 Compare October 4, 2023 08:37
This was referenced Oct 5, 2023
Merged
Closed
@m-Peter m-Peter mentioned this pull request Oct 9, 2023
Merged
6 tasks
SupunS
SupunS approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🎉 👏

test/test_runner.go Show resolved Hide resolved
@SupunS SupunS merged commit de381d8 into onflow:master Oct 13, 2023
7 checks passed
@m-Peter m-Peter deleted the unit-testing-improvements branch October 23, 2023 08:00
@SupunS SupunS mentioned this pull request Oct 30, 2023
Open
This was referenced Jun 3, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluesign bluesign bluesign left review comments

@SupunS SupunS SupunS approved these changes

@turbolent turbolent Awaiting requested review from turbolent turbolent is a code owner

@dsainati1 dsainati1 Awaiting requested review from dsainati1

Assignees

@SupunS SupunS

Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Milestone
No milestone
3 participants
@m-Peter @SupunS @bluesign