Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LS] Bump onflow/cadence dependency to v0.42.0 #220

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Oct 9, 2023

Depends on: #210

Description

Also adds a default implementation for the ContractUpdateRecorded method.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the dependency versions 🙏

However, we might need to update Cadence version for all other dependencies of LS (i.e: transitive dependencies). For e.g: LS depends on flowkit, lint, flow-go-sdk, etc, which again depends on an older version of Cadence. Having two versions of Cadence in the dependency tree could cause some unexpected behaviors for some of these modules. i.e: They could pick the newer version of Cadence for which that module is not tested yet.
(Unfortunately, that's a problem with Go dependency resolution)

@m-Peter
Copy link
Contributor Author

m-Peter commented Oct 15, 2023

That's a good point 👍
Regarding lint, there's already a PR open: #219. But I think the flow-go-sdk latest version is not updated to cadence@v0.42.0.
I have opened another PR for updating flow-emulator to cadence@v0.42.0 and latest flow-go: onflow/flow-emulator#483
I am in need of these updates in order to merge onflow/flow-cli#1227 😅 🙏
We can then release the uplift for the Cadence testing framework.
Let me know how can I help on my part, to speed up the process.

Update: Also opened onflow/flow-go-sdk#488

@m-Peter m-Peter force-pushed the ls-update-cadence-version branch from d39fd24 to a8edd7c Compare October 16, 2023 11:37
@m-Peter
Copy link
Contributor Author

m-Peter commented Oct 18, 2023

I have updated flow-go-sdk and cadence-tools/lint dependencies. I think flowkit is a circular dependency, so it will have to be updated last, after this PR is merged.

@SupunS SupunS merged commit 6b3b4c3 into onflow:master Oct 19, 2023
7 checks passed
@m-Peter m-Peter deleted the ls-update-cadence-version branch October 23, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants