Update test command with latest features from Cadence testing framework #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
m-Peter
force-pushed
the
update-tests-with-latest-features
branch
from
738739d to
f0c78cb
Compare
6 tasks
…uageserver repository
m-Peter
force-pushed
the
update-tests-with-latest-features
branch
from
e700b17 to
1706dfa
Compare
m-Peter
requested review from
Kay-Zee,
janezpodhostnik,
sideninja,
chasefleming,
nvdtf and
jribbink
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1227 +/- ##
==========================================
+ Coverage 38.65% 40.67% +2.02%
==========================================
Files 38 38
Lines 1948 1974 +26
==========================================
+ Hits 753 803 +50
+ Misses 1107 1082 -25
- Partials 88 89 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…ce-tools/test dependencies
SupunS
reviewed
Oct 23, 2023
|
LGTM nice changes |
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
SupunS
approved these changes
Oct 24, 2023
| @@ -35,6 +35,7 @@ require ( | |||
| cloud.google.com/go/compute/metadata v0.2.3 // indirect | |||
| cloud.google.com/go/iam v1.1.1 // indirect | |||
| cloud.google.com/go/kms v1.12.1 // indirect | |||
| github.com/DataDog/zstd v1.4.5 // indirect | |||
There was a problem hiding this comment.
Why is datadog added here? Is this adding some sort of reporting?
There was a problem hiding this comment.
It is an indirect dependency from some direct dependency:
github.com/DataDog/zstd
This module is necessary because [github.com/DataDog/zstd](vscode-file://vscode-app/snap/code/143/usr/share/code/resources/app/out/vs/code/electron-sandbox/workbench/workbench.html) is imported in:
- github.com/onflow/flow-cli/internal/accounts
-- github.com/onflow/flow-cli/flowkit/gateway
--- github.com/onflow/flow-go/model/flow
---- github.com/onflow/flow-go/model/flow.test
----- github.com/onflow/flow-go/utils/unittest
------ github.com/cockroachdb/pebble
------- github.com/cockroachdb/pebble/sstable| @@ -49,6 +50,12 @@ require ( | |||
| github.com/cespare/xxhash/v2 v2.2.0 // indirect | |||
| github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e // indirect | |||
| github.com/cloudflare/circl v1.1.0 // indirect | |||
| github.com/cockroachdb/errors v1.8.1 // indirect | |||
There was a problem hiding this comment.
Same here:
github.com/cockroachdb/errors
This module is necessary because [github.com/cockroachdb/errors](vscode-file://vscode-app/snap/code/143/usr/share/code/resources/app/out/vs/code/electron-sandbox/workbench/workbench.html) is imported in:
- github.com/onflow/flow-cli/internal/accounts
-- github.com/onflow/flow-cli/flowkit/gateway
--- github.com/onflow/flow-go/model/flow
---- github.com/onflow/flow-go/model/flow.test
----- github.com/onflow/flow-go/utils/unittest
------ github.com/cockroachdb/pebble
chasefleming
approved these changes
Oct 25, 2023
chasefleming
added
the
Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: onflow/cadence-tools#210
Work towards: onflow/developer-grants#216
Description
Incorporates the latest features from the Cadence testing framework:
testingnetworkimportResolverto handleAddressLocationFor contributor use:
masterbranchFiles changedin the Github PR explorer