Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax Highlighting: Add support for embeddedLanguages #2998

Open
bryphe opened this issue Jan 15, 2021 · 2 comments
Open

Syntax Highlighting: Add support for embeddedLanguages #2998

bryphe opened this issue Jan 15, 2021 · 2 comments
Labels
A-syntax-highlighting Area: Syntax Highlighting enhancement New feature or request

Comments

@bryphe
Copy link
Member

bryphe commented Jan 15, 2021 •
edited
Loading

Related to #2985 - add support for embeddedLanguages and bring the PHP HTML embedded languages back (#2997)
@bryphe bryphe added A-syntax-highlighting Area: Syntax Highlighting enhancement New feature or request labels Jan 15, 2021
@bryphe bryphe mentioned this issue Jan 15, 2021
Merged
bryphe added a commit that referenced this issue Jan 15, 2021
@bryphe
fix(syntax/#2985): PHP syntax highlights not showing (#2997)
a4661f7 
__Issue:__ PHP syntax highlights are no longer showing by default

__Defect:__ #2889 upgraded the extensions, but the PHP extension has a new dependency on `embeddedLanguages`, which our current textmate implementation does not handle correctly

__Fix:__ Remove the `embeddedLanguages` for now - add a regression / canary test to ensure we don't break this in the future.

Fixes #2985 
Tracking `embeddedLanguage` support in #2998
@creeefs
Copy link

creeefs commented Jan 19, 2021 •
edited
Loading

Is it fair to categorize this Svelte issue (#2989) as related to this feature?

@pmizio
Copy link

pmizio commented Jan 27, 2021

I belive it is also related:
#2118

@bryphe bryphe mentioned this issue Mar 5, 2021
Open
@bryphe bryphe mentioned this issue Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-syntax-highlighting Area: Syntax Highlighting enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@creeefs @pmizio @bryphe