Skip to content

Comments

[SE-4495] Update said-oxford release branch#372

Closed
gabor-boros wants to merge 26 commits intoesme-oxford-release/koa.3from
gabor/backport-edx-platform-celery-koa
Closed

[SE-4495] Update said-oxford release branch#372
gabor-boros wants to merge 26 commits intoesme-oxford-release/koa.3from
gabor/backport-edx-platform-celery-koa

Conversation

@gabor-boros
Copy link

@gabor-boros gabor-boros commented Jul 12, 2021

Pull latest opencraft-release/koa.3 changes and celerybeat fix


This Pull Request adds CELERYBEAT_SCHEDULER to the edx-platform and sets it to its default value defined by Celery documentation.

The configuration repository PR: open-craft/configuration#171

Settings

ADDL_INSTALLED_APPS:
- django_celery_beat

EDXAPP_ENABLE_CELERY_BEAT: true
SANDBOX_ENABLE_REDIS: true
EDXAPP_CELERY_BROKER_TRANSPORT: 'redis'
EDXAPP_CELERY_BROKER_HOSTNAME: '127.0.0.1:6379'
EDXAPP_CELERY_BROKER_USE_SSL: false
EDXAPP_CELERY_BROKER_VHOST: '/0'
EDXAPP_CELERY_USER: 'default'
EDXAPP_CELERY_PASSWORD: ''
EDXAPP_CELERYBEAT_SCHEDULER: django_celery_beat.schedulers:DatabaseScheduler

Dependencies:

open-craft/configuration#171

Sandbox URL: https://372-sbs.opencraft.hosting/

Merge deadline: ASAP

Testing instructions:

First of all, do an instance test checklist!

  • Login using the edX user
  • Navigate to the Instructor dashboard's download tab
  • Click on Download profile information as a CSV
  • Scroll down to the bottom of the page and wait some seconds
  • Validate that the generated report appears and downloadable

Author notes and concerns:

TBD

Reviewers

  • (OpenCraft internal reviewer's GitHub username goes here)
  • edX reviewer[s] TBD

gabor-boros and others added 25 commits May 5, 2021 17:07
…27359) (#349)

* fix: address VisibleBlocks caching race condition
* sets visual block creation in an atomic transaction
* refactor: add logging statement to bulk create

Co-authored-by: Raul Gallegos <raul@opencraft.com>

Co-authored-by: Raul Gallegos <raul@opencraft.com>
Adds toggle REDIRECT_UNAUTHENTICATED_USER_TO_LOGIN_ON_ENROLL
for enrollment behaviour for unauthenticated user.
If true, the user will be redirected to 'signin_user' route.

Co-authored-by: Arjun Singh Yadav <arjun@opencraft.com>
* Add course creation condition for organization

The condition added to ensure that if the feature is enabled
user will not be able to create the course outside of the organization
in which they belong.

Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
…354)

certificate issued date

(cherry picked from commit 421e661)
When getting a subsection grade for a user, instead of failing
if the user can't access that subsection,
fallback to the collected structure.
This reverts commit 8910ccf.

Our clients are no longer using this feature, and edX won't accept this
upstream as-is currently.  See https://github.com/edx/edx-platform/pull/23735 for more information.

Reverting to reduce code drift from upstream.
[BB-4218] Update Arabic translations - Koa
…ggle

FAL-867 Revert "Unhide student-generated certificates toggle"
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
…on_settings_page_backport

[BB-4385] Prevent course details AJAX request from getting into browser history (backport)
* Update celery routing

- Used routing function instead of class
- Move task queues dictionary to Django settings
- Removed routing_key parameter
- Refactored routing for singleton celery instantiation

Co-authored-by: Awais Qureshi <awais.qureshi@arbisoft.com>
(cherry picked from commit e3b4d23)
The required `set_code_owner_attribute` decorator was introduced in
v3.12.0, therefore we need to bump the dependency.

(cherry picked from commit f52b84e)
…360)

Co-authored-by: Nizar Mahmoud <nizarmah@hotmail.com>
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
The action buttons in wiki modal have href attribute
but does not have an event listener for click.
This PR changes the buttons to anchor tags so that they
work as expected when clicked.
fix: change buttons in wiki modal to anchor tags
Makes HIGH_PRIORITY_QUEUE a derived setting, which allows
HEARTBEAT_CELERY_ROUTING_KEY to use the correct config variant default.

(cherry picked from commit 2a9067a)
The allowlisted certificates were getting invalidated upon visiting the Course
Progress page by users.

This is a rough backport of the Lilac fix (edx#26356). In Lilac, this is gated
by the `certificates_revamp.use_allowlist` Waffle flag. In post-Lilac branches,
this is working out of the box (the flag has been removed in edx#27576).

Jira ticket: BB-4287
[FAL-2076] Cherry-pick celery fixes on Koa.3
@gabor-boros gabor-boros changed the title [SE-4495] Update [SE-4495] Update said-oxford release branch Jul 12, 2021
@gabor-boros gabor-boros force-pushed the gabor/backport-edx-platform-celery-koa branch from bc557a4 to 69e302e Compare July 12, 2021 14:08
@gabor-boros gabor-boros force-pushed the gabor/backport-edx-platform-celery-koa branch 2 times, most recently from 7f064ab to 1acb8e2 Compare July 13, 2021 17:10
@gabor-boros
Copy link
Author

gabor-boros commented Jul 13, 2021

replaced by #374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.