[SE-4495] Update said-oxford release branch #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds toggle REDIRECT_UNAUTHENTICATED_USER_TO_LOGIN_ON_ENROLL for enrollment behaviour for unauthenticated user. If true, the user will be redirected to 'signin_user' route. Co-authored-by: Arjun Singh Yadav <arjun@opencraft.com>
* Add course creation condition for organization The condition added to ensure that if the feature is enabled user will not be able to create the course outside of the organization in which they belong. Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
When getting a subsection grade for a user, instead of failing if the user can't access that subsection, fallback to the collected structure.
This reverts commit 8910ccf. Our clients are no longer using this feature, and edX won't accept this upstream as-is currently. See https://github.com/edx/edx-platform/pull/23735 for more information. Reverting to reduce code drift from upstream.
[BB-4218] Update Arabic translations - Koa
…ggle FAL-867 Revert "Unhide student-generated certificates toggle"
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
…on_settings_page_backport [BB-4385] Prevent course details AJAX request from getting into browser history (backport)
* Update celery routing - Used routing function instead of class - Move task queues dictionary to Django settings - Removed routing_key parameter - Refactored routing for singleton celery instantiation Co-authored-by: Awais Qureshi <awais.qureshi@arbisoft.com> (cherry picked from commit e3b4d23)
(cherry picked from commit d1060d2)
The required `set_code_owner_attribute` decorator was introduced in v3.12.0, therefore we need to bump the dependency. (cherry picked from commit f52b84e)
…360) Co-authored-by: Nizar Mahmoud <nizarmah@hotmail.com>
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
The action buttons in wiki modal have href attribute but does not have an event listener for click. This PR changes the buttons to anchor tags so that they work as expected when clicked.
fix: change buttons in wiki modal to anchor tags
Makes HIGH_PRIORITY_QUEUE a derived setting, which allows HEARTBEAT_CELERY_ROUTING_KEY to use the correct config variant default. (cherry picked from commit 2a9067a)
The allowlisted certificates were getting invalidated upon visiting the Course Progress page by users. This is a rough backport of the Lilac fix (edx#26356). In Lilac, this is gated by the `certificates_revamp.use_allowlist` Waffle flag. In post-Lilac branches, this is working out of the box (the flag has been removed in edx#27576). Jira ticket: BB-4287
[FAL-2076] Cherry-pick celery fixes on Koa.3
2 tasks
…form-celery-koa-esme
nizarmah
approved these changes
Jul 14, 2021
nizarmah
left a comment
nizarmah
left a comment
There was a problem hiding this comment.
👍
- I tested this by following the manual instance test checklist, which includes the testing instructions from this pull request.
-
I read through the code -
I checked for accessibility issues -
Includes documentation
bradenmacdonald
deleted the
gabor/backport-edx-platform-celery-koa-esme
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull latest opencraft-release/koa.3 changes and celerybeat fix
This Pull Request adds
CELERYBEAT_SCHEDULERto the edx-platform and sets it to its default value defined by Celery documentation.The configuration repository PR: open-craft/configuration#171
Settings
Dependencies:
open-craft/configuration#171
Sandbox URL: https://372-sbs.opencraft.hosting/
Merge deadline: ASAP
Testing instructions:
First of all, do an instance test checklist!
Author notes and concerns:
TBD
Reviewers