Silence warning on Solaris. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the hwloc_solaris_get_chip_type and hwloc_solaris_get_chip_model macros are defined before the prototype is defined.
bgoglin
added a commit
that referenced
this pull request
Aug 12, 2014
See #1 with further simplify/uniformify from me. Thanks to Gilles Gouaillardet
|
Thanks, I pushed it together with the removal of another #include (to make things uniform across all topology files). Also backported to stable branches up to OMPI's v1.7 |
This was referenced Sep 12, 2014
Closed
Closed
NicolasDenoyelle
pushed a commit
to NicolasDenoyelle/dynamic_lstopo
that referenced
this pull request
Dec 11, 2014
indexes=8*2:4*2 specifies that we nest 2 interleaving loops: one loop with 2 steps with 8 between each, then one loop with 2 steps with 4 between each. PU#0 and open-mpi#1 will be 8 PU away, and PU#0 and open-mpi#2 will be 4 PU away.
bgoglin
added a commit
that referenced
this pull request
Oct 26, 2016
netloc: new design The code of Netloc was simplified and cleaned up, with new data types. The main netloc API isn't installed during make install since it may still change in the future. Tools were reorganized under utils/netloc/. A draw tool was added to visualize a topology in a web browser (under utils/netloc/draw/). Netloc can interact with the Scotch partitioning tool by creating Scotch "architectures" from the network topology, and by generating a rank file for MPI from a Scotch mapping. This is the only part of the netloc API that is already public and installed during make install (when scotch is detected). Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
bgoglin
added a commit
that referenced
this pull request
Mar 16, 2018
On a 4-core machine with #2 offline, we want x86 to look at all 4 cores, so that we get info for all online ones (#1, #3 and #4). Before this commit, x86 would only look at the 3 first ones (just like if the offline PUs were always at the end of the range). At least Linux and Solaris can put some CPUs offline in the middle of the index range. So ask hwloc_fallback_nbprocessors() to get the number of existing CPUs. Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the hwloc_solaris_get_chip_type and hwloc_solaris_get_chip_model
macros are defined before the prototype is defined.
In order to reproduce the issue
$ hwloc_symbol_prefix_value=hwloc_git_ /.../configure --enable-debug --enable-picky
then
$ cd src
$ make topology-solaris-chiptype.lo
CC topology-solaris-chiptype.lo
In file included from /export/home/gilles/src/hwloc/include/hwloc.h:59:0,
from ../../../src/hwloc/src/topology-solaris-chiptype.c:17:
/export/home/gilles/build/hwloc/include/hwloc/autogen/config.h:197:26: warning: no previous prototype for 'hwloc_git_hwloc_solaris_get_chip_type' [-Wmissing-prototypes]
#define HWLOC_SYM_PREFIX hwloc_git_
^
/export/home/gilles/src/hwloc/include/hwloc/rename.h:29:33: note: in definition of macro 'HWLOC_MUNGE_NAME2'
#define HWLOC_MUNGE_NAME2(a, b) a ## b
^
/export/home/gilles/src/hwloc/include/hwloc/rename.h:30:26: note: in expansion of macro 'HWLOC_MUNGE_NAME'
#define HWLOC_NAME(name) HWLOC_MUNGE_NAME(HWLOC_SYM_PREFIX, hwloc_ ## name)
^
/export/home/gilles/src/hwloc/include/hwloc/rename.h:30:43: note: in expansion of macro 'HWLOC_SYM_PREFIX'
#define HWLOC_NAME(name) HWLOC_MUNGE_NAME(HWLOC_SYM_PREFIX, hwloc_ ## name)
^
/export/home/gilles/src/hwloc/include/hwloc/rename.h:630:37: note: in expansion of macro 'HWLOC_NAME'
#define hwloc_solaris_get_chip_type HWLOC_NAME(solaris_get_chip_type)
^
../../../src/hwloc/src/topology-solaris-chiptype.c:284:7: note: in expansion of macro 'hwloc_solaris_get_chip_type'
char* hwloc_solaris_get_chip_type(void) {
^
/export/home/gilles/build/hwloc/include/hwloc/autogen/config.h:197:26: warning: no previous prototype for 'hwloc_git_hwloc_solaris_get_chip_model' [-Wmissing-prototypes]
#define HWLOC_SYM_PREFIX hwloc_git_
^
/export/home/gilles/src/hwloc/include/hwloc/rename.h:29:33: note: in definition of macro 'HWLOC_MUNGE_NAME2'
#define HWLOC_MUNGE_NAME2(a, b) a ## b
^
/export/home/gilles/src/hwloc/include/hwloc/rename.h:30:26: note: in expansion of macro 'HWLOC_MUNGE_NAME'
#define HWLOC_NAME(name) HWLOC_MUNGE_NAME(HWLOC_SYM_PREFIX, hwloc_ ## name)
^
/export/home/gilles/src/hwloc/include/hwloc/rename.h:30:43: note: in expansion of macro 'HWLOC_SYM_PREFIX'
#define HWLOC_NAME(name) HWLOC_MUNGE_NAME(HWLOC_SYM_PREFIX, hwloc_ ## name)
^
/export/home/gilles/src/hwloc/include/hwloc/rename.h:631:38: note: in expansion of macro 'HWLOC_NAME'
#define hwloc_solaris_get_chip_model HWLOC_NAME(solaris_get_chip_model)
^
../../../src/hwloc/src/topology-solaris-chiptype.c:321:7: note: in expansion of macro 'hwloc_solaris_get_chip_model'
char *hwloc_solaris_get_chip_model(void) {