Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMS H5_W1 #1513

Merged
merged 11 commits into from
Jul 31, 2023
Merged

LMS H5_W1 #1513

merged 11 commits into from
Jul 31, 2023

Conversation

ashman-p
Copy link
Contributor

Add support for LMS key generation, LMS sign, and verify. LMS variant H=5, W=1.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [Y] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@ashman-p ashman-p requested review from xvzcf and dstebila as code owners July 23, 2023 22:08
@ashman-p
Copy link
Contributor Author

Any idea what changed in this PR to cause static analysis errors in XMSS tests. Any ideas anyone?

@ashman-p
Copy link
Contributor Author

Any idea what changed in this PR to cause static analysis errors in XMSS tests. Any ideas anyone?

Never mind... Just saw a note from Duc.

@ashman-p ashman-p requested a review from ducnguyen-sb July 24, 2023 20:58
@ducnguyen-sb
Copy link
Contributor

Let me convert the uint64_t to unsigned long long. Somehow I think it's safer to use uint64_t instead of unsigned long long.

@ducnguyen-sb
Copy link
Contributor

@ashman-p , I've fixed all the problem with XMSS.
Thank you for letting me know.
There is a minor bug in LMS scan-build, I can fix it for you if you want.

@ashman-p
Copy link
Contributor Author

Thanks Duc, Can you just post the diffs here and i can update and clean up the branch.
Thanks.

@ducnguyen-sb
Copy link
Contributor

Yes I will.

@ducnguyen-sb ducnguyen-sb force-pushed the na-stateful-sigs/lms branch from 1598e06 to 181776d Compare July 25, 2023 17:02
@ducnguyen-sb
Copy link
Contributor

ducnguyen-sb commented Jul 25, 2023

@ashman-p , so I revert my commit to 181776d, and generate a patch below.

patch.txt

@ashman-p ashman-p marked this pull request as draft July 29, 2023 15:53
@ashman-p ashman-p marked this pull request as ready for review July 29, 2023 21:41
Copy link
Contributor

@ducnguyen-sb ducnguyen-sb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for committing my PR to fix XMSS syntax.

@ashman-p ashman-p merged commit b69aa67 into stateful-sigs Jul 31, 2023
@dstebila dstebila deleted the na-stateful-sigs/lms branch August 2, 2023 14:23
dstebila pushed a commit that referenced this pull request Aug 18, 2023
* Support LMS H5_W1

* Fix style check

* Rename CmakeLists.txt CMakeLists.txt

* Add namespace

* Address issues from scan results

* Address SA issue

* Fix formatting

* Fix formatting

* Commit Duc's SA fixes

* Fix mem leak, and compiler warning.
SWilson4 pushed a commit that referenced this pull request Dec 15, 2023
* Support LMS H5_W1

* Fix style check

* Rename CmakeLists.txt CMakeLists.txt

* Add namespace

* Address issues from scan results

* Address SA issue

* Fix formatting

* Fix formatting

* Commit Duc's SA fixes

* Fix mem leak, and compiler warning.
SWilson4 pushed a commit that referenced this pull request Feb 14, 2024
* Support LMS H5_W1

* Fix style check

* Rename CmakeLists.txt CMakeLists.txt

* Add namespace

* Address issues from scan results

* Address SA issue

* Fix formatting

* Fix formatting

* Commit Duc's SA fixes

* Fix mem leak, and compiler warning.
cothan pushed a commit that referenced this pull request Apr 2, 2024
* Support LMS H5_W1

* Fix style check

* Rename CmakeLists.txt CMakeLists.txt

* Add namespace

* Address issues from scan results

* Address SA issue

* Fix formatting

* Fix formatting

* Commit Duc's SA fixes

* Fix mem leak, and compiler warning.
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
* Support LMS H5_W1

* Fix style check

* Rename CmakeLists.txt CMakeLists.txt

* Add namespace

* Address issues from scan results

* Address SA issue

* Fix formatting

* Fix formatting

* Commit Duc's SA fixes

* Fix mem leak, and compiler warning.
SWilson4 pushed a commit that referenced this pull request May 14, 2024
* Support LMS H5_W1

* Fix style check

* Rename CmakeLists.txt CMakeLists.txt

* Add namespace

* Address issues from scan results

* Address SA issue

* Fix formatting

* Fix formatting

* Commit Duc's SA fixes

* Fix mem leak, and compiler warning.
ashman-p added a commit that referenced this pull request Jun 4, 2024
commit e356ebf Na lms (#1486)
commit 55094c3 LMS H5_W1 (#1513)
commit 4d773d7 Convert to use OQS_SIG_STFL_SECRET_KEY struct  (#1525)
commit 245aede LMS updated to use new SK API (#1533)
commit a85a9aa Stateful sigs secret key storage callback (#1553)
commit 3934949 Na statful sig lock (#1559)
commit 3db6b44 Secret Key Query  (#1572)
commit 2446c64 Na stateful sigs lms var (#1574)
commit 8df2539 Stateful sigs XMSS updates (#1590)
commit a7b2987 SHA2 Increment with arbitrary length (non-block sizes) (#1614)
commit 2dd9e07 Na lms kat multi level (#1620)
commit 982b440 Fix Build Errors (#1635)
commit ddae644 Various fixes
commit cc50ef0 Fix warning
commit cf03392 Update README.md
commit 9325713 Update README.md
commit a52b217 Update README.md
commit d442ac9 Update README.md
commit 72ab478 Update README.md
commit 5967f12 Update src/CMakeLists.txt
commit fc6d512 Update documentation and license text. (#1663)
commit e7a83c7 Disable Stateful Signatures in the build by default (#1676)
commit 6c81bae Na stateful macro (#1687)

Signed-off-by: Norman Ashley <nashley@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants