Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stateful sigs secret key storage callback #1553

Merged
merged 9 commits into from
Sep 22, 2023
Merged

Stateful sigs secret key storage callback #1553

merged 9 commits into from
Sep 22, 2023

Conversation

ashman-p
Copy link
Contributor

Added capability to write secret key to file.

  1. Create secret key
  2. Generate key pair and set app specific context associated with the secret key. This context is used when updating the secret key.
  3. Secret key is updated after each sign operation.
  4. App manages the context and deletes associated memory when the key is deleted
  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@ashman-p ashman-p requested a review from dstebila as a code owner September 15, 2023 03:47
@ashman-p ashman-p requested review from ducnguyen-sb, dstebila and SWilson4 and removed request for dstebila September 15, 2023 03:47
SWilson4
SWilson4 requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@SWilson4 SWilson4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me barring the one memory safety issue.

Edit to add: Although it seems like this issue was already present---is this function not yet tested?

src/sig_stfl/lms/sig_stfl_lms_functions.c Show resolved Hide resolved
ducnguyen-sb
ducnguyen-sb reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ducnguyen-sb ducnguyen-sb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashman-p for this PR. I just have a few minor request changes.
Other than that the PR looks good to me.

src/sig_stfl/lms/sig_stfl_lms.c Outdated Show resolved Hide resolved
src/sig_stfl/lms/sig_stfl_lms.c Outdated Show resolved Hide resolved
src/sig_stfl/lms/sig_stfl_lms.h Show resolved Hide resolved
src/sig_stfl/sig_stfl.c Outdated Show resolved Hide resolved
src/sig_stfl/sig_stfl.c Outdated Show resolved Hide resolved
@ashman-p ashman-p merged commit 62b0a34 into stateful-sigs Sep 22, 2023
@ashman-p ashman-p deleted the stateful-sigs-cb branch October 4, 2023 04:30
SWilson4 pushed a commit that referenced this pull request Dec 15, 2023
@ashman-p @SWilson4
Stateful sigs secret key storage callback (#1553)
64a941b 
* Callback implemention updating secret key.

* Block XMSS from secret key tests until after support code has been added.

* Remove / from test file names

* Format

* Address SA issues

* Fix mem leak

* Fix mem leak

* Address various comments

* Fix SA issue
SWilson4 pushed a commit that referenced this pull request Feb 14, 2024
@ashman-p @SWilson4
Stateful sigs secret key storage callback (#1553)
9645168 
* Callback implemention updating secret key.

* Block XMSS from secret key tests until after support code has been added.

* Remove / from test file names

* Format

* Address SA issues

* Fix mem leak

* Fix mem leak

* Address various comments

* Fix SA issue
cothan pushed a commit that referenced this pull request Apr 2, 2024
@ashman-p @cothan
Stateful sigs secret key storage callback (#1553)
897209e 
* Callback implemention updating secret key.

* Block XMSS from secret key tests until after support code has been added.

* Remove / from test file names

* Format

* Address SA issues

* Fix mem leak

* Fix mem leak

* Address various comments

* Fix SA issue
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ashman-p @SWilson4
Stateful sigs secret key storage callback (#1553)
6808110 
* Callback implemention updating secret key.

* Block XMSS from secret key tests until after support code has been added.

* Remove / from test file names

* Format

* Address SA issues

* Fix mem leak

* Fix mem leak

* Address various comments

* Fix SA issue
SWilson4 pushed a commit that referenced this pull request May 14, 2024
@ashman-p @SWilson4
Stateful sigs secret key storage callback (#1553)
a85a9aa 
* Callback implemention updating secret key.

* Block XMSS from secret key tests until after support code has been added.

* Remove / from test file names

* Format

* Address SA issues

* Fix mem leak

* Fix mem leak

* Address various comments

* Fix SA issue
ashman-p added a commit that referenced this pull request Jun 4, 2024
@ashman-p
I, Norman Ashley, retroactively sign off on these commits:
3621a6b 
commit e356ebf Na lms (#1486)
commit 55094c3 LMS H5_W1 (#1513)
commit 4d773d7 Convert to use OQS_SIG_STFL_SECRET_KEY struct  (#1525)
commit 245aede LMS updated to use new SK API (#1533)
commit a85a9aa Stateful sigs secret key storage callback (#1553)
commit 3934949 Na statful sig lock (#1559)
commit 3db6b44 Secret Key Query  (#1572)
commit 2446c64 Na stateful sigs lms var (#1574)
commit 8df2539 Stateful sigs XMSS updates (#1590)
commit a7b2987 SHA2 Increment with arbitrary length (non-block sizes) (#1614)
commit 2dd9e07 Na lms kat multi level (#1620)
commit 982b440 Fix Build Errors (#1635)
commit ddae644 Various fixes
commit cc50ef0 Fix warning
commit cf03392 Update README.md
commit 9325713 Update README.md
commit a52b217 Update README.md
commit d442ac9 Update README.md
commit 72ab478 Update README.md
commit 5967f12 Update src/CMakeLists.txt
commit fc6d512 Update documentation and license text. (#1663)
commit e7a83c7 Disable Stateful Signatures in the build by default (#1676)
commit 6c81bae Na stateful macro (#1687)

Signed-off-by: Norman Ashley <nashley@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducnguyen-sb ducnguyen-sb ducnguyen-sb approved these changes

@SWilson4 SWilson4 SWilson4 approved these changes

@dstebila dstebila Awaiting requested review from dstebila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashman-p @SWilson4 @ducnguyen-sb