Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret Key Query #1572

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Secret Key Query #1572

merged 3 commits into from
Oct 5, 2023

Conversation

ashman-p
Copy link
Contributor

@ashman-p ashman-p commented Oct 4, 2023

Query the number of signing operations a private key can handle in total as well as the number
of signing operations that has already been done..

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@ashman-p ashman-p requested a review from dstebila as a code owner October 4, 2023 05:33
@ashman-p ashman-p self-assigned this Oct 4, 2023
@ashman-p ashman-p requested a review from ducnguyen-sb October 4, 2023 13:00
@ducnguyen-sb
Copy link
Contributor

Thanks @ashman-p , I only have one question. Other than that the PR LGTM!

@ashman-p
Copy link
Contributor Author

ashman-p commented Oct 4, 2023

Thanks @ashman-p , I only have one question. Other than that the PR LGTM!

Thank you. Also, you will see that some of the tests only address LMS but that will change once the relevant callback features have been added to XMSS.

@ashman-p ashman-p merged commit 443d662 into stateful-sigs Oct 5, 2023
@ashman-p ashman-p deleted the na-stateful-sig-qry branch October 5, 2023 18:19
SWilson4 pushed a commit that referenced this pull request Dec 15, 2023
@ashman-p @SWilson4
Secret Key Query (#1572)
753c650 
* Added functions to query the total, as well as, the remaining numbers of signing operation for a given secret key.

* Cleanup unused variable

* Fix code style
SWilson4 pushed a commit that referenced this pull request Feb 14, 2024
@ashman-p @SWilson4
Secret Key Query (#1572)
8c728c0 
* Added functions to query the total, as well as, the remaining numbers of signing operation for a given secret key.

* Cleanup unused variable

* Fix code style
cothan pushed a commit that referenced this pull request Apr 2, 2024
@ashman-p @cothan
Secret Key Query (#1572)
f68d903 
* Added functions to query the total, as well as, the remaining numbers of signing operation for a given secret key.

* Cleanup unused variable

* Fix code style
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ashman-p @SWilson4
Secret Key Query (#1572)
78f3b9f 
* Added functions to query the total, as well as, the remaining numbers of signing operation for a given secret key.

* Cleanup unused variable

* Fix code style
SWilson4 pushed a commit that referenced this pull request May 14, 2024
@ashman-p @SWilson4
Secret Key Query (#1572)
3db6b44 
* Added functions to query the total, as well as, the remaining numbers of signing operation for a given secret key.

* Cleanup unused variable

* Fix code style
ashman-p added a commit that referenced this pull request Jun 4, 2024
@ashman-p
I, Norman Ashley, retroactively sign off on these commits:
3621a6b 
commit e356ebf Na lms (#1486)
commit 55094c3 LMS H5_W1 (#1513)
commit 4d773d7 Convert to use OQS_SIG_STFL_SECRET_KEY struct  (#1525)
commit 245aede LMS updated to use new SK API (#1533)
commit a85a9aa Stateful sigs secret key storage callback (#1553)
commit 3934949 Na statful sig lock (#1559)
commit 3db6b44 Secret Key Query  (#1572)
commit 2446c64 Na stateful sigs lms var (#1574)
commit 8df2539 Stateful sigs XMSS updates (#1590)
commit a7b2987 SHA2 Increment with arbitrary length (non-block sizes) (#1614)
commit 2dd9e07 Na lms kat multi level (#1620)
commit 982b440 Fix Build Errors (#1635)
commit ddae644 Various fixes
commit cc50ef0 Fix warning
commit cf03392 Update README.md
commit 9325713 Update README.md
commit a52b217 Update README.md
commit d442ac9 Update README.md
commit 72ab478 Update README.md
commit 5967f12 Update src/CMakeLists.txt
commit fc6d512 Update documentation and license text. (#1663)
commit e7a83c7 Disable Stateful Signatures in the build by default (#1676)
commit 6c81bae Na stateful macro (#1687)

Signed-off-by: Norman Ashley <nashley@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstebila dstebila Awaiting requested review from dstebila

@ducnguyen-sb ducnguyen-sb Awaiting requested review from ducnguyen-sb

Assignees

@ashman-p ashman-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashman-p @ducnguyen-sb