Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Flexible Task Definitions #168

Merged
merged 102 commits into from
Feb 13, 2022
Merged

Support Flexible Task Definitions #168

merged 102 commits into from
Feb 13, 2022

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Feb 8, 2022

DRAFT

Support the flexible task definition framework as discussed here #107 and introduced here open-rmf/rmf_task#39.

Checklist before merging: #153

Features introduced (TODO):

  • Schemas:
  • Websocket client for task/robot states and logs
  • ...

Yadunund and others added 30 commits December 6, 2021 18:21
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
…mentation

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
…mentation

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
…sting

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
youliangtan and others added 4 commits February 11, 2022 18:06
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@mxgrey mxgrey marked this pull request as ready for review February 12, 2022 12:22
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #168 (de6f6c2) into main (3e52711) will decrease coverage by 0.94%.
The diff coverage is n/a.

❗ Current head de6f6c2 differs from pull request most recent head f4f90c3. Consider uploading reports for the commit f4f90c3 to get more accurate results

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   20.46%   19.52%   -0.95%     
==========================================
  Files         398      852     +454     
  Lines       33882    78232   +44350     
  Branches    16040    37936   +21896     
==========================================
+ Hits         6933    15272    +8339     
- Misses      19419    46360   +26941     
- Partials     7530    16600    +9070     
Flag Coverage Δ
tests 19.52% <ø> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...adapter/include/rmf_fleet_adapter/agv/Waypoint.hpp
...4.1.0/Rx/v2/src/rxcpp/schedulers/rx-sameworker.hpp
...ffic_ros2/src/rmf_traffic_ros2/schedule/Writer.cpp
...2/test/mock_schedule_nodes/missing_participant.cpp
...dapter/src/read_only_blockade/FleetAdapterNode.hpp
.../rmf_traffic_ros2/test/unit/test_convert_Graph.cpp
...os2/rmf_fleet_adapter/src/lift_supervisor/Node.cpp
...ffic_ros2/test/mock_schedule_nodes/wrong_query.cpp
...ter/src/rmf_fleet_adapter/agv/EasyTrafficLight.cpp
...2/rmf_fleet_adapter/rmf_rxcpp/examples/TestMap.hpp
... and 1240 more

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Copy link
Contributor

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some very niche CI test issues that will need some follow-up attention, but overall this is looking good enough to ship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants