Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the CMake user package registry can do unexpected things. #47

Merged
merged 2 commits into from
Nov 14, 2021

Conversation

codebot
Copy link
Contributor

@codebot codebot commented Nov 11, 2021

The CMake user package registry can cause unexpected behavior if people aren't accustomed to it. This PR removes the export(PACKAGE ...) invocation that adds to the user package registry in ~/.cmake/packages during the colcon build/install process.

Signed-off-by: Morgan Quigley morgan@osrfoundation.org

Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@codebot codebot requested a review from mxgrey November 11, 2021 03:16
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #47 (6dd4075) into main (355ce10) will not change coverage.
The diff coverage is n/a.

❗ Current head 6dd4075 differs from pull request most recent head a0c04a8. Consider uploading reports for the commit a0c04a8 to get more accurate results

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   38.76%   38.76%           
=======================================
  Files          29       29           
  Lines        1656     1656           
  Branches     1002     1002           
=======================================
  Hits          642      642           
  Misses        248      248           
  Partials      766      766           
Flag Coverage Δ
tests 38.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Yadunund Yadunund merged commit a548bac into main Nov 14, 2021
@Yadunund Yadunund deleted the feature/dont_use_cmake_user_package_registry branch November 14, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants