Use ament_cmake_uncrustify #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
force-pushed
the
use_ament_cmake_uncrustify
branch
from
c979dbe to
9787234
Compare
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 38.76% 38.76%
=======================================
Files 29 29
Lines 1656 1656
Branches 1002 1002
=======================================
Hits 642 642
Misses 248 248
Partials 766 766
Flags with carried forward coverage won't be shown. Click here to find out more. |
aaronchongth
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have the rmf_cmake_uncrustify package that is used for style checking with colcon test. The original reason for having this package and not using ament_cmake_uncrustify was that the latter did not support custom uncrustify configuration files. But this feature was merged upstream quite a while ago and has been part of
foxyandgalacticreleases. Hence, switching back toament_cmake_uncrustifyfor ease of maintenance and distribution.