Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always link rmf_traffic against the Threads target #74

Merged
merged 2 commits into from
May 20, 2022
Merged

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Apr 22, 2022

open-rmf/rmf_demos#132 reported that their machine failed to link rmf_traffic against pthread. In theory this PR should fix that problem.

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #74 (517e27b) into main (50f3211) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   23.14%   23.14%           
=======================================
  Files         370      370           
  Lines       30583    30583           
  Branches    14262    14262           
=======================================
  Hits         7079     7079           
  Misses      14103    14103           
  Partials     9401     9401           
Flag Coverage Δ
tests 23.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cottsay
Copy link
Contributor

cottsay commented May 19, 2022

I believe that this PR will solve one of the issues preventing rmf_traffic_examples from successfully building RPM packages for RHEL: https://build.ros2.org/view/Rbin_rhel_el864/job/Rbin_rhel_el864__rmf_traffic_examples__rhel_8_x86_64__binary/

EDIT: And also rmf_battery builds: https://build.ros2.org/view/Rbin_rhel_el864/job/Rbin_rhel_el864__rmf_battery__rhel_8_x86_64__binary/

@mxgrey mxgrey merged commit 439eba0 into main May 20, 2022
@mxgrey mxgrey deleted the link_threads branch May 20, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants