-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable AI description generator on comments #285
Conversation
1a4aa6b
to
f3c9fc9
Compare
DescriptionGeneratorButton
I could not check why the comment button but opened that in a new issue to make merging this easier/faster. |
Coming back to this issue, I wonder, do we need the AI description enabled for comments? Isn't supposed to be just for the PR description? I haven't worked with this feature really, so maybe that was something requested by users? |
I am not sure about that, but for this I felt the need for it when I update a PR and have multiple commits on it, I would like to write a comment with the latest PR changes instead of updating the PR description, which is the use use for this. |
The description would be generated on all the changes made to the PR not only the latest. So wonder if that would be helpful when adding a follow-up description to the PR. |
You are right, this would be helpful if you have changed the logic of the PR and would like to write a follow up or even just get full summary after changes and need to write the changes happened, I have faced a similar case previously but not sure in what PR. In that case, I had to change the initial implantation and write the changes in a comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code 👍👍
## [1.15.0-beta.1](v1.14.3-beta.3...v1.15.0-beta.1) (2024-01-12) ### 🍕 Features * enable AI description generator on comments ([#285](#285)) ([a30380b](a30380b))
🎉 This PR is included in version 1.15.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.15.0](v1.14.2...v1.15.0) (2024-01-30) ### 🐛 Bug Fixes * add `.gitattributes` file and normalize all the line endings ([#301](#301)) ([a6279ea](a6279ea)) * change the classname and remove extra code ([241c385](241c385)) * chunk processing in Chat component ([#289](#289)) ([f1c29ff](f1c29ff)) * elemenet to the dom if it's not added already ([c654b82](c654b82)) * Link to Usage Guide and Update README ([#298](#298)) ([ba5cef6](ba5cef6)) ### 🍕 Features * enable AI description generator on comments ([#285](#285)) ([a30380b](a30380b)) * Upgrade to v2 API ([693d459](693d459))
🎉 This PR is included in version 1.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This is PR is a second part of #282, if we merge the one before we will have less edits here, did not feel to have one large PR.
At this PR, I just enabled the AI description generator in comments and refactored the code based on that.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #283
Closes #288
Mobile & Desktop Screenshots/Recordings
Before:
After:
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?