fix: correct position of create highlight button #1565
Conversation
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Great stuff @himanshumalviya15
We were actually looking at something like this #1519 (comment)
Maybe this will work for now, but is that something you would like to work on?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
This solves the problem, but we will do another design pass later. I am good with merge this for now. Just need another approval. |
Yea... Sure LGTM 🍕 |
brandonroberts
changed the title
|
@bdougie We can have a merge now |
## [1.61.0](v1.60.0...v1.61.0) (2023-08-24) ### 🍕 Features * "Following" button to "Unfollow" on hover ([#1588](#1588)) ([721cc36](721cc36)) * add Maintainer badge to dashboard `HoverCard` and `ContributorCard` ([#1586](#1586)) ([ea34f7e](ea34f7e)) * add subscription management section to user settings ([#1587](#1587)) ([3ceb2c8](3ceb2c8)) * highlight blogs ([#1555](#1555)) ([4058f79](4058f79)) * Support full URLs when adding repo to insights page ([#1470](#1470)) ([ee53414](ee53414)) ### 🐛 Bug Fixes * "53y" showing up as first PR age in Contributor hover Card for dashboard ([#1609](#1609)) ([03522c9](03522c9)) * add bg color to reports select filter ([#1570](#1570)) ([90f381c](90f381c)) * correct position of create highlight button ([#1565](#1565)) ([2ce44bd](2ce44bd)) * corrected Alignment for mobile view ([#1578](#1578)) ([0d23330](0d23330)) * corrected repo card for mobile ([#1577](#1577)) ([779862d](779862d)) * fix crash on `/user/[username]` route due to browser support issue ([#1580](#1580)) ([336a43e](336a43e)) * highlights nav item unselected when there were query params in URL ([#1584](#1584)) ([68c3916](68c3916)) * highlights page endless flicker on tab change (1576) ([#1582](#1582)) ([56a3da9](56a3da9)) * keep UserCard from leaving the viewport on sticky sidebar ([#1585](#1585)) ([5b33b13](5b33b13)) * overflows in insights page on md screen size ([#1590](#1590)) ([69ec31e](69ec31e)) * query param reset in repo filters & URL encoding ([#1597](#1597)) ([c5c7df3](c5c7df3)) * refetch following count after following a user ([#1596](#1596)) ([cb31fd1](cb31fd1)) * remove tagged repos from highlight ([#1595](#1595)) ([26a2be6](26a2be6)) * show checkbox for repos table in small screens ([#1559](#1559)) ([a6e6bb3](a6e6bb3)) * update react-spring imports and upgrade @react-spring/web ([#1567](#1567)) ([44c80af](44c80af))
#1560
Description
corrected position of create highlight button, it is overlaping with live chat button in mobile
What type of PR is this? (check all applicable)
Related Tickets & Documents
#1560
Mobile & Desktop Screenshots/Recordings
Before
After
Added tests?
Added to documentation?