Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: hide the chat bubble on the highlights page #1519

Closed
bdougie opened this issue Aug 8, 2023 · 5 comments
Closed

bug: hide the chat bubble on the highlights page #1519

bdougie opened this issue Aug 8, 2023 · 5 comments
Labels
💡 feature needs design Front-end tasks that are missing a design. Create a new issue for the design.

Comments

@bdougie
Copy link
Member

bdougie commented Aug 8, 2023

image

This is only needed to be hidden for mobile only.

@babblebey
Copy link
Contributor

babblebey commented Aug 8, 2023

IMHO, I think it can be a bottleneck for UX, if I wanted to use the chat bubble and I have to navigate to another page if I was on the highlights page, if I wasn't told I would'nt even know!?

If we've decided to show the chat bubble on all other pages, I'm very curious to know, why are we hiding on highlight page?

If this reason is because if how the chat bubs co-exist with the highlight button, I would've suggested that we work on letting them co-exist better preferably over hiding it.

PS: I think we need to be very intentional with decisions taken for mobile UX, this arguably is the source device for the most traffic to websites.

@bdougie
Copy link
Member Author

bdougie commented Aug 8, 2023

Perhaps we need a need design for mobile highlights.

Not sure the context behind the pencil but you bring up some great points to discuss @babblebey

we can rethink this user experience and interaction. Looking at how twitter handles this we can provide a way for these interactions to co-exist.

image

Hiding chat bubble but adding that functionality to the pencil is possible.

@babblebey
Copy link
Contributor

Great stuff, I think we can do that for sure.

So this means we'd have the sitegpt button and new highlight button within the drawer on mobile.

Screenshot_2023-08-08-16-12-55-873_com.twitter.android.jpg

@takanome-dev
Copy link
Contributor

We were actually looking at something like this #1519 (comment)

Maybe this will work for now, but is that something you would like to work on?
Originally posted by @babblebey in #1565 (review)

This solves the problem, but we will do another design pass later. I am good with merge this for now.

Originally posted by @bdougie in #1565 (comment)

Let's make this issue a feature request. As mentioned in the quoted reply, design is needed here.

@takanome-dev takanome-dev added 💡 feature needs design Front-end tasks that are missing a design. Create a new issue for the design. labels Aug 16, 2023
@bdougie bdougie closed this as completed Sep 19, 2023
@nickytonline
Copy link
Member

Perhaps we need a need design for mobile highlights.

Not sure the context behind the pencil but you bring up some great points to discuss @babblebey

we can rethink this user experience and interaction. Looking at how twitter handles this we can provide a way for these interactions to co-exist.

image

Hiding chat bubble but adding that functionality to the pencil is possible.

Was thinking the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature needs design Front-end tasks that are missing a design. Create a new issue for the design.
Projects
No open projects
Development

No branches or pull requests

4 participants