Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Remove tailwinds anti-pattern in Hero.tsx #315

Closed
Tracked by #267
bdougie opened this issue Aug 16, 2022 · 10 comments · Fixed by #337
Closed
Tracked by #267

Remove tailwinds anti-pattern in Hero.tsx #315

bdougie opened this issue Aug 16, 2022 · 10 comments · Fixed by #337
Labels
🍕 enhancement New feature or request released on @alpha released on @beta released

Comments

@bdougie
Copy link
Member

bdougie commented Aug 16, 2022 •
edited
Loading

Context is on the tracking issue - #267

This issue only needs changes to this file.
@bdougie bdougie mentioned this issue Aug 16, 2022
Closed
7 tasks
@bdougie bdougie added the 🍕 enhancement New feature or request label Aug 16, 2022
@bdougie bdougie changed the title Remove tailwinds anti-pattern Hero.tsx Remove tailwinds anti-pattern in Hero.tsx Aug 16, 2022
@AlexVCS
Copy link
Contributor

AlexVCS commented Sep 6, 2022

.take

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Thanks for taking this on! If you have not already, join the conversation in our Discord

This was referenced Sep 8, 2022
Closed
Merged
@ghost
Copy link

ghost commented Oct 3, 2022

.take

@github-actions github-actions bot assigned ghost Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Thanks for taking this on! If you have not already, join the conversation in our Discord

@bdougie
Copy link
Member Author

bdougie commented Oct 3, 2022

This is mostly completed on this open PR - https://github.com/open-sauced/hot/pull/337/files#diff-1cadf8397b7345b9f320a7c7e007a8bc697f2c9deec3085de9bd17e057ac0f0a

The only question was the use of rems was not ideal and I don't think I saw a response from @AlexVCS on why.

@AlexVCS
Copy link
Contributor

AlexVCS commented Oct 3, 2022

My apologies @bdougie! I've changed the code to use Tailwind's default spacing scale instead of hardcoding rem values.

@bdougie bdougie closed this as completed in 549e676 Oct 4, 2022
github-actions bot pushed a commit that referenced this issue Oct 4, 2022
@AlexVCS @open-sauced
chore(minor): release 2.25.0-beta.8 on beta channel [skip ci]
0cb48bb 
## [2.25.0-beta.8](v2.25.0-beta.7...v2.25.0-beta.8) (2022-10-04)

### 🍕 Features

* added custom tailwind variables and removed anti patterns ([#337](#337)) ([549e676](549e676)), closes [#315](#315)
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

🎉 This issue has been resolved in version 2.25.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Oct 5, 2022
@bdougie @open-sauced
chore(minor): release 2.26.0-beta.1 on beta channel [skip ci]
9330b3e 
## [2.26.0-beta.1](v2.25.0...v2.26.0-beta.1) (2022-10-05)

### 🐛 Bug Fixes

* rename everything from Post to Repo  ([#356](#356)) ([0267009](0267009)), closes [#313](#313)

### 🍕 Features

* added custom tailwind variables and removed anti patterns ([#337](#337)) ([549e676](549e676)), closes [#315](#315)
* adds localstorageprovider ([#361](#361)) ([f030796](f030796)), closes [#335](#335)
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

🎉 This issue has been resolved in version 2.26.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Oct 18, 2022
@0-vortex @open-sauced
chore(minor): release 2.26.0-alpha.3 on alpha channel [skip ci]
d23d91a 
## [2.26.0-alpha.3](v2.26.0-alpha.2...v2.26.0-alpha.3) (2022-10-18)

### 🍕 Features

* added custom tailwind variables and removed anti patterns ([#337](#337)) ([549e676](549e676)), closes [#315](#315)
* adds localstorageprovider ([#361](#361)) ([f030796](f030796)), closes [#335](#335)
* New Favicon Replacement ([#363](#363)) ([bb680a6](bb680a6)), closes [#362](#362)
* Update SVG favicon ([#369](#369)) ([bf78ca0](bf78ca0)), closes [#368](#368)

### 🐛 Bug Fixes

* add menu drop to generate token on console ([#367](#367)) ([dce7249](dce7249)), closes [#364](#364)
* correct upstream fast forward ([2897584](2897584))
* remove swr local storage cache provider ([#371](#371)) ([334081c](334081c)), closes [#365](#365)
* rename everything from Post to Repo  ([#356](#356)) ([0267009](0267009)), closes [#313](#313)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.26.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Oct 28, 2022
@0-vortex @open-sauced
chore(minor): release 2.26.0 [skip ci]
38168e4 
## [2.26.0](v2.25.0...v2.26.0) (2022-10-28)

### 🐛 Bug Fixes

* add menu drop to generate token on console ([#367](#367)) ([dce7249](dce7249)), closes [#364](#364)
* add open a bug link when repo loading fails ([#349](#349)) ([50efbc8](50efbc8)), closes [#307](#307)
* alpha build ([#360](#360)) ([06a5ef2](06a5ef2))
* correct [#321](#321) changes ([0080521](0080521))
* correct alpha mistakes ([#381](#381)) ([f917ac2](f917ac2))
* correct latest alpha ([6e82aa6](6e82aa6))
* correct merge conflicts from bad heads ([566f753](566f753))
* correct upstream fast forward ([2897584](2897584))
* remove swr local storage cache provider ([#371](#371)) ([334081c](334081c)), closes [#365](#365)
* rename everything from Post to Repo  ([#356](#356)) ([0267009](0267009)), closes [#313](#313)
* trigger build on alpha ([#359](#359)) ([dbbbea5](dbbbea5))

### 🍕 Features

* add loading skeleton for the repoWrap component ([#374](#374)) ([058beab](058beab)), closes [#357](#357)
* add myVotes filter for repo list ([#384](#384)) ([e0e70ed](e0e70ed)), closes [#334](#334)
* added custom tailwind variables and removed anti patterns ([#337](#337)) ([549e676](549e676)), closes [#315](#315)
* adds localstorageprovider ([#361](#361)) ([f030796](f030796)), closes [#335](#335)
* auth/session API call temporary at Navbar component. ([#379](#379)) ([841b635](841b635)), closes [#366](#366)
* display repos' contributors avatars ([#383](#383)) ([ecebb1e](ecebb1e)), closes [#333](#333)
* **api:** leverage the api over sdk ([#321](#321)) ([a471317](a471317)), closes [#312](#312) [#312](#312) [#312](#312)
* make recent the default filter ([#377](#377)) ([3ace891](3ace891)), closes [#376](#376) [#380](#380)
* new favicon ([#389](#389)) ([67ab18b](67ab18b))
* New Favicon Replacement ([#363](#363)) ([bb680a6](bb680a6)), closes [#362](#362)
* Update SVG favicon ([#369](#369)) ([bf78ca0](bf78ca0)), closes [#368](#368)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🍕 enhancement New feature or request released on @alpha released on @beta released
Projects
None yet
Milestone
No milestone
2 participants
@bdougie @AlexVCS