Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Feature: Create a "failed to load" state for the repository cards #307

Closed
2 tasks done
NsdHSO opened this issue Aug 11, 2022 · 7 comments · Fixed by #349
Closed
2 tasks done

Feature: Create a "failed to load" state for the repository cards #307

NsdHSO opened this issue Aug 11, 2022 · 7 comments · Fixed by #349

Comments

@NsdHSO
Copy link
Contributor

NsdHSO commented Aug 11, 2022

Type of feature

🎨 Style

Current behavior

If we don't find some resources we showed this
image

Suggested solution

Just an example
image

but you can put your imagination to work for you

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@0-vortex
Copy link
Contributor

If we make the "not found" error clickable, it should open an issue here saying "X repo could not be loaded" - the top 3 should normally load 😅 🍕

@NsdHSO
Copy link
Contributor Author

NsdHSO commented Aug 11, 2022

@pixelsbyeryc we need your wisdom, can you please help? 🙏

@eryc-cc eryc-cc changed the title Feature: Not found resources Feature: Create a "failed to load" state for the repository cards Aug 12, 2022
@eryc-cc
Copy link

eryc-cc commented Aug 12, 2022

If we make the "not found" error clickable, it should open an issue here saying "X repo could not be loaded" - the top 3 should normally load 😅 🍕

@NsdHSO I would just add a ⚠️ or ℹ️ icon (not emojis, actual icons) by the side of the text that says "X repo could not be loaded", and a link to open a new issue (that opens in a new tab), like @0-vortex suggested.

In terms of design, I would make the text and icon a lighter shade of gray (or slate), and center everything in the card.

@NsdHSO
Copy link
Contributor Author

NsdHSO commented Sep 29, 2022

.take

@github-actions
Copy link

Thanks for taking this on! If you have not already, join the conversation in our Discord

NsdHSO added a commit to NsdHSO/hot that referenced this issue Sep 29, 2022
NsdHSO added a commit to NsdHSO/hot that referenced this issue Sep 29, 2022
NsdHSO added a commit to NsdHSO/hot that referenced this issue Oct 9, 2022
github-actions bot pushed a commit that referenced this issue Oct 25, 2022
## [2.26.0-beta.11](v2.26.0-beta.10...v2.26.0-beta.11) (2022-10-25)

### 🐛 Bug Fixes

* add open a bug link when repo loading fails ([#349](#349)) ([50efbc8](50efbc8)), closes [#307](#307)

### 🍕 Features

* add myVotes filter for repo list ([#384](#384)) ([e0e70ed](e0e70ed)), closes [#334](#334)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.26.0-beta.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Oct 28, 2022
## [2.26.0](v2.25.0...v2.26.0) (2022-10-28)

### 🐛 Bug Fixes

* add menu drop to generate token on console ([#367](#367)) ([dce7249](dce7249)), closes [#364](#364)
* add open a bug link when repo loading fails ([#349](#349)) ([50efbc8](50efbc8)), closes [#307](#307)
* alpha build ([#360](#360)) ([06a5ef2](06a5ef2))
* correct [#321](#321) changes ([0080521](0080521))
* correct alpha mistakes ([#381](#381)) ([f917ac2](f917ac2))
* correct latest alpha ([6e82aa6](6e82aa6))
* correct merge conflicts from bad heads ([566f753](566f753))
* correct upstream fast forward ([2897584](2897584))
* remove swr local storage cache provider ([#371](#371)) ([334081c](334081c)), closes [#365](#365)
* rename everything from Post to Repo  ([#356](#356)) ([0267009](0267009)), closes [#313](#313)
* trigger build on alpha ([#359](#359)) ([dbbbea5](dbbbea5))

### 🍕 Features

* add loading skeleton for the repoWrap component ([#374](#374)) ([058beab](058beab)), closes [#357](#357)
* add myVotes filter for repo list ([#384](#384)) ([e0e70ed](e0e70ed)), closes [#334](#334)
* added custom tailwind variables and removed anti patterns ([#337](#337)) ([549e676](549e676)), closes [#315](#315)
* adds localstorageprovider ([#361](#361)) ([f030796](f030796)), closes [#335](#335)
* auth/session API call temporary at Navbar component. ([#379](#379)) ([841b635](841b635)), closes [#366](#366)
* display repos' contributors avatars ([#383](#383)) ([ecebb1e](ecebb1e)), closes [#333](#333)
* **api:** leverage the api over sdk ([#321](#321)) ([a471317](a471317)), closes [#312](#312) [#312](#312) [#312](#312)
* make recent the default filter ([#377](#377)) ([3ace891](3ace891)), closes [#376](#376) [#380](#380)
* new favicon ([#389](#389)) ([67ab18b](67ab18b))
* New Favicon Replacement ([#363](#363)) ([bb680a6](bb680a6)), closes [#362](#362)
* Update SVG favicon ([#369](#369)) ([bf78ca0](bf78ca0)), closes [#368](#368)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants