This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
feat: add loading skeleton for the repoWrap component #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hot-sauced-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
LGTM |
bdougie
suggested changes
Oct 18, 2022
There was a problem hiding this comment.
This looks visually great. The only concern is the skeleton is added after the data fetch.
We should follow this pattern here. https://github.com/open-sauced/hot/blob/beta/src/components/HotRepoCard.tsx#L35-L44
bdougie
approved these changes
Oct 20, 2022
|
🎉 This PR is included in version 2.26.0-beta.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
## [2.26.0](v2.25.0...v2.26.0) (2022-10-28) ### 🐛 Bug Fixes * add menu drop to generate token on console ([#367](#367)) ([dce7249](dce7249)), closes [#364](#364) * add open a bug link when repo loading fails ([#349](#349)) ([50efbc8](50efbc8)), closes [#307](#307) * alpha build ([#360](#360)) ([06a5ef2](06a5ef2)) * correct [#321](#321) changes ([0080521](0080521)) * correct alpha mistakes ([#381](#381)) ([f917ac2](f917ac2)) * correct latest alpha ([6e82aa6](6e82aa6)) * correct merge conflicts from bad heads ([566f753](566f753)) * correct upstream fast forward ([2897584](2897584)) * remove swr local storage cache provider ([#371](#371)) ([334081c](334081c)), closes [#365](#365) * rename everything from Post to Repo ([#356](#356)) ([0267009](0267009)), closes [#313](#313) * trigger build on alpha ([#359](#359)) ([dbbbea5](dbbbea5)) ### 🍕 Features * add loading skeleton for the repoWrap component ([#374](#374)) ([058beab](058beab)), closes [#357](#357) * add myVotes filter for repo list ([#384](#384)) ([e0e70ed](e0e70ed)), closes [#334](#334) * added custom tailwind variables and removed anti patterns ([#337](#337)) ([549e676](549e676)), closes [#315](#315) * adds localstorageprovider ([#361](#361)) ([f030796](f030796)), closes [#335](#335) * auth/session API call temporary at Navbar component. ([#379](#379)) ([841b635](841b635)), closes [#366](#366) * display repos' contributors avatars ([#383](#383)) ([ecebb1e](ecebb1e)), closes [#333](#333) * **api:** leverage the api over sdk ([#321](#321)) ([a471317](a471317)), closes [#312](#312) [#312](#312) [#312](#312) * make recent the default filter ([#377](#377)) ([3ace891](3ace891)), closes [#376](#376) [#380](#380) * new favicon ([#389](#389)) ([67ab18b](67ab18b)) * New Favicon Replacement ([#363](#363)) ([bb680a6](bb680a6)), closes [#362](#362) * Update SVG favicon ([#369](#369)) ([bf78ca0](bf78ca0)), closes [#368](#368)
|
🎉 This PR is included in version 2.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
0-vortex
added a commit
that referenced
this pull request
Nov 11, 2022
* origin/main: chore(minor): release 2.27.0 [skip ci] chore(minor): release 2.27.0-beta.1 on beta channel [skip ci] feat: organize voted repo list by week (#393) chore(patch): release 2.26.1-beta.1 on beta channel [skip ci] fix: star us on GitHub button redirect (#392) chore(minor): release 2.26.0 [skip ci] chore(minor): release 2.26.0-beta.12 on beta channel [skip ci] feat: new favicon (#389) chore(minor): release 2.26.0-beta.11 on beta channel [skip ci] feat: add myVotes filter for repo list (#384) fix: add open a bug link when repo loading fails (#349) chore(minor): release 2.26.0-beta.10 on beta channel [skip ci] feat: display repos' contributors avatars (#383) chore(minor): release 2.26.0-beta.9 on beta channel [skip ci] feat: auth/session API call temporary at Navbar component. (#379) chore(minor): release 2.26.0-beta.8 on beta channel [skip ci] feat: add loading skeleton for the repoWrap component (#374) chore(minor): release 2.26.0-beta.7 on beta channel [skip ci] feat: make recent the default filter (#377) chore(minor): release 2.26.0-beta.6 on beta channel [skip ci]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR adds 5 loading skeleton for the
repoWrapcomponentRelated Tickets & Documents
Fixes #357
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?