Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Downgrade mattn/go-ieproxy to fix the Windows build #16423

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Nov 22, 2022

Pin github.com/mattn/go-ieproxy back to 0.0.1 to fix Windows build https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3519443048/jobs/5899625893. The dependency was upgraded in #16418 indirectly from https://github.com/snowflakedb/gosnowflake which also got it rolled back snowflakedb/gosnowflake#689

See mattn/go-ieproxy#45

@dmitryax dmitryax requested a review from a team November 22, 2022 05:44
@dmitryax dmitryax requested a review from mx-psi as a code owner November 22, 2022 05:44
@github-actions github-actions bot added cmd/configschema configschema command receiver/sqlquery SQL query receiver labels Nov 22, 2022
@github-actions github-actions bot requested a review from pmcollins November 22, 2022 05:45
@dmitryax dmitryax force-pushed the downgrade-go-ieproxy branch from e0d1b41 to 25853a1 Compare November 22, 2022 06:38
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a PR on releases to add the replace there

@mx-psi mx-psi merged commit 8cea4e1 into open-telemetry:main Nov 22, 2022
@dmitryax dmitryax deleted the downgrade-go-ieproxy branch November 22, 2022 17:26
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command receiver/sqlquery SQL query receiver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants