Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a case in case portal does not update pagination #332

Closed
pamag opened this issue Jan 12, 2022 · 2 comments
Closed

Deleting a case in case portal does not update pagination #332

pamag opened this issue Jan 12, 2022 · 2 comments
Assignees
Labels
bug devel_info issues with good documentation about software functionality or code. Good for code review
Milestone

Comments

@pamag
Copy link
Member

pamag commented Jan 12, 2022

Describe the bug

Deleting a case, removes it from the table but it does not fill the table from the other elements from pagination.

Proposed fix

After deleting a case, the table needs to be refreshed but user should be in the same pagination index that before, unless deleting the last case of a table. In that case user should be presented the previous page.

Related issues

#320
#384
#385

@pamag pamag added the bug label Jan 12, 2022
@pamag pamag added this to the v2.2.0 milestone Jan 12, 2022
@Rodielm
Copy link
Contributor

Rodielm commented Jan 13, 2022

Fixed d31ba8f

The misbehaviour occurs because the data comes from the server and for the table this is the only data it knows, even if you change the pagination the table forgets the previous data.

If the data came from the client side and the table had a pagination of 5 rows, the table would know the size of the data and would know how to manage the pagination.

@pamag pamag added the devel_info issues with good documentation about software functionality or code. Good for code review label Jan 13, 2022
@pamag
Copy link
Member Author

pamag commented Jan 29, 2022

Reviewed

commit 958d4ef

FIXED with issues

Closed and opened two new issues
Deleting a case in case portal does not add the next available case at the end of the page #384

Deleting the last case in a page of the case portal does not show the previous page #385

@pamag pamag closed this as completed Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug devel_info issues with good documentation about software functionality or code. Good for code review
Projects
None yet
Development

No branches or pull requests

2 participants