This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Write detection code path in callbacks #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
reviewed
Mar 4, 2020
| } else { | ||
| LOG.warn(NULL_RESPONSE + " {} for {}", modelID, rcfNodeID); | ||
| } | ||
| } finally { |
There was a problem hiding this comment.
Catch exception and log it ?
ylwu-amzn
reviewed
Mar 4, 2020
| this.endTime = endTime; | ||
| this.nodeCount = nodeCount; | ||
| this.responseCount = responseCount; | ||
| this.adID = adID; | ||
| } | ||
|
|
||
| @Override | ||
| public void onResponse(RCFResultResponse response) { |
There was a problem hiding this comment.
onResponse will be called multiple times if send request to multiple nodes?
* add AD job on top of JobScheduler * release job lock when job finish or fail * upgrade jobscheduler to 1.4
ylwu-amzn
approved these changes
Mar 6, 2020
zhanghg08
reviewed
Mar 6, 2020
| } | ||
|
|
||
| @Test | ||
| public void testRunJobWithLocakDuration() throws InterruptedException { |
There was a problem hiding this comment.
That’s actually from rebased code. not the code meant to be reviewed. I fixed it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we actively wait for rcf and threshold model requests to return in transport thread. The active wait blocks transport thread. To increase concurrency and improve performance, we change detection code path to use callbacks.
Testing done: