Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finetuned yolov5 for trucks #476

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Finetuned yolov5 for trucks #476

merged 11 commits into from
Nov 15, 2023

Conversation

BillMousta
Copy link
Collaborator

This pull request introduces a new download method within the YOLOv5DetectorLearner class, enabling automated fetching of pre-trained models directly into the local environment. Additionally, it showcases an inference demo leveraging a YOLOv5s model fine-tuned for enhanced truck detection accuracy. This demonstration serves as a practical example of the model's improved performance in identifying trucks.

@omichel
Copy link
Collaborator

omichel commented Nov 8, 2023

This PR has many conflicts. Could you please fix them before requesting a review?

@omichel omichel marked this pull request as draft November 8, 2023 07:30
@passalis passalis changed the base branch from master to develop November 8, 2023 07:35
@passalis
Copy link
Collaborator

passalis commented Nov 8, 2023

I changed the target to develop, which I think resolved the conflicts. If tests pass, then I think we can proceed with the review.

@passalis passalis marked this pull request as ready for review November 8, 2023 07:38
@tsampazk tsampazk added test sources Run style checks test tools Test the toolkit methods labels Nov 8, 2023
@tsampazk tsampazk self-requested a review November 8, 2023 09:16
Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few comments that needs to be addressed, along with the missing documentation.

@passalis
Copy link
Collaborator

If this PR is ready for review, please let us know.

@BillMousta BillMousta requested a review from passalis November 13, 2023 09:10
Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. One minor typo fix.

docs/reference/object-detection-2d-yolov5.md Outdated Show resolved Hide resolved
BillMousta and others added 2 commits November 14, 2023 10:24
Copy link
Collaborator

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
Thank you.

Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@passalis passalis merged commit 503a646 into develop Nov 15, 2023
47 checks passed
@passalis passalis deleted the finetuned-yolov5-for-trucks branch November 15, 2023 11:09
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BillMousta for the new feature! I have added some comments, most are minor.

One general comment: I am not sure about the naming of the new feature. We use the word trucks which is not really accurate since the model is trained on tractors, so it could be misleading. Reading trucks i would intuitively expect pickup trucks or semis. Let me know if i misunderstand something regarding the naming.

tsampazk added a commit that referenced this pull request Nov 15, 2023
@tsampazk
Copy link
Collaborator

Hmm it seems that you beat me to it. There are several stuff that need some polishing with this PR. I will implement the changes i commented on and open a new PR.

@tsampazk tsampazk mentioned this pull request Nov 15, 2023
Pavlos-Tosidis added a commit that referenced this pull request Nov 20, 2023
* Finetuned yolov5 for trucks (#476)

* Yolov5 learner truck updates

* Yolov5 create an inference demo for the finetuned model

* Update object-detection-2d-yolov5.md

yolov5_learner.py documentation for download method

* Update object-detection-2d-yolov5.md

* Refactor yolov5_learner.py download process in constructor for efficiency

* Update docs/reference/object-detection-2d-yolov5.md

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>

---------

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Yolov5 trucks fixes (#487)

* Some fixes and additions on the yolov5 download method doc

* Minor addition for model name yolov5 trucks

* Some fixes for the yolov5 download method docstring

---------

Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com>
Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
passalis added a commit that referenced this pull request Nov 29, 2023
* Changed Face Recognition inference return. Now class is 0/1 if not found/found
Added feature_extraction method to get access to features from a face image
Added active_demo in which features in database get updated with new features of the same person.

* Added final carriage return

* Develop (#489)

* Finetuned yolov5 for trucks (#476)

* Yolov5 learner truck updates

* Yolov5 create an inference demo for the finetuned model

* Update object-detection-2d-yolov5.md

yolov5_learner.py documentation for download method

* Update object-detection-2d-yolov5.md

* Refactor yolov5_learner.py download process in constructor for efficiency

* Update docs/reference/object-detection-2d-yolov5.md

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>

---------

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Yolov5 trucks fixes (#487)

* Some fixes and additions on the yolov5 download method doc

* Minor addition for model name yolov5 trucks

* Some fixes for the yolov5 download method docstring

---------

Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com>
Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

* Added:
A simple demo for active feature updates
A RosNode to be used by Pal_Robotics for the healthcare use case
Fixed pep8 errors
Added Readme's

* Added:
Fixed pep8 errors

* Update projects/opendr_ws/src/opendr_perception/scripts/active_face_recognition_node.py

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

* Update src/opendr/perception/face_recognition/face_recognition_learner.py

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

---------

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
* Yolov5 learner truck updates

* Yolov5 create an inference demo for the finetuned model

* Update object-detection-2d-yolov5.md

yolov5_learner.py documentation for download method

* Update object-detection-2d-yolov5.md

* Refactor yolov5_learner.py download process in constructor for efficiency

* Update docs/reference/object-detection-2d-yolov5.md

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>

---------

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
* Changed Face Recognition inference return. Now class is 0/1 if not found/found
Added feature_extraction method to get access to features from a face image
Added active_demo in which features in database get updated with new features of the same person.

* Added final carriage return

* Develop (opendr-eu#489)

* Finetuned yolov5 for trucks (opendr-eu#476)

* Yolov5 learner truck updates

* Yolov5 create an inference demo for the finetuned model

* Update object-detection-2d-yolov5.md

yolov5_learner.py documentation for download method

* Update object-detection-2d-yolov5.md

* Refactor yolov5_learner.py download process in constructor for efficiency

* Update docs/reference/object-detection-2d-yolov5.md

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>

---------

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Yolov5 trucks fixes (opendr-eu#487)

* Some fixes and additions on the yolov5 download method doc

* Minor addition for model name yolov5 trucks

* Some fixes for the yolov5 download method docstring

---------

Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com>
Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

* Added:
A simple demo for active feature updates
A RosNode to be used by Pal_Robotics for the healthcare use case
Fixed pep8 errors
Added Readme's

* Added:
Fixed pep8 errors

* Update projects/opendr_ws/src/opendr_perception/scripts/active_face_recognition_node.py

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

* Update src/opendr/perception/face_recognition/face_recognition_learner.py

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

---------

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test sources Run style checks test tools Test the toolkit methods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants