-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finetuned yolov5 for trucks #476
Conversation
This PR has many conflicts. Could you please fix them before requesting a review? |
I changed the target to |
…gin/develop' into finetuned-yolov5-for-trucks
…o finetuned-yolov5-for-trucks
yolov5_learner.py documentation for download method
…o finetuned-yolov5-for-trucks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few comments that needs to be addressed, along with the missing documentation.
src/opendr/perception/object_detection_2d/yolov5/yolov5_learner.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/object_detection_2d/yolov5/yolov5_learner.py
Outdated
Show resolved
Hide resolved
If this PR is ready for review, please let us know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. One minor typo fix.
Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @BillMousta for the new feature! I have added some comments, most are minor.
One general comment: I am not sure about the naming of the new feature. We use the word trucks which is not really accurate since the model is trained on tractors, so it could be misleading. Reading trucks i would intuitively expect pickup trucks or semis. Let me know if i misunderstand something regarding the naming.
projects/python/perception/object_detection_2d/yolov5/inference_demo_agriculture_vehicles.py
Show resolved
Hide resolved
Hmm it seems that you beat me to it. There are several stuff that need some polishing with this PR. I will implement the changes i commented on and open a new PR. |
* Finetuned yolov5 for trucks (#476) * Yolov5 learner truck updates * Yolov5 create an inference demo for the finetuned model * Update object-detection-2d-yolov5.md yolov5_learner.py documentation for download method * Update object-detection-2d-yolov5.md * Refactor yolov5_learner.py download process in constructor for efficiency * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> --------- Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Yolov5 trucks fixes (#487) * Some fixes and additions on the yolov5 download method doc * Minor addition for model name yolov5 trucks * Some fixes for the yolov5 download method docstring --------- Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
* Changed Face Recognition inference return. Now class is 0/1 if not found/found Added feature_extraction method to get access to features from a face image Added active_demo in which features in database get updated with new features of the same person. * Added final carriage return * Develop (#489) * Finetuned yolov5 for trucks (#476) * Yolov5 learner truck updates * Yolov5 create an inference demo for the finetuned model * Update object-detection-2d-yolov5.md yolov5_learner.py documentation for download method * Update object-detection-2d-yolov5.md * Refactor yolov5_learner.py download process in constructor for efficiency * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> --------- Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Yolov5 trucks fixes (#487) * Some fixes and additions on the yolov5 download method doc * Minor addition for model name yolov5 trucks * Some fixes for the yolov5 download method docstring --------- Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Added: A simple demo for active feature updates A RosNode to be used by Pal_Robotics for the healthcare use case Fixed pep8 errors Added Readme's * Added: Fixed pep8 errors * Update projects/opendr_ws/src/opendr_perception/scripts/active_face_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/face_recognition/face_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> --------- Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
* Yolov5 learner truck updates * Yolov5 create an inference demo for the finetuned model * Update object-detection-2d-yolov5.md yolov5_learner.py documentation for download method * Update object-detection-2d-yolov5.md * Refactor yolov5_learner.py download process in constructor for efficiency * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> --------- Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
* Changed Face Recognition inference return. Now class is 0/1 if not found/found Added feature_extraction method to get access to features from a face image Added active_demo in which features in database get updated with new features of the same person. * Added final carriage return * Develop (opendr-eu#489) * Finetuned yolov5 for trucks (opendr-eu#476) * Yolov5 learner truck updates * Yolov5 create an inference demo for the finetuned model * Update object-detection-2d-yolov5.md yolov5_learner.py documentation for download method * Update object-detection-2d-yolov5.md * Refactor yolov5_learner.py download process in constructor for efficiency * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> --------- Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Yolov5 trucks fixes (opendr-eu#487) * Some fixes and additions on the yolov5 download method doc * Minor addition for model name yolov5 trucks * Some fixes for the yolov5 download method docstring --------- Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Added: A simple demo for active feature updates A RosNode to be used by Pal_Robotics for the healthcare use case Fixed pep8 errors Added Readme's * Added: Fixed pep8 errors * Update projects/opendr_ws/src/opendr_perception/scripts/active_face_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/face_recognition/face_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> --------- Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
This pull request introduces a new download method within the YOLOv5DetectorLearner class, enabling automated fetching of pre-trained models directly into the local environment. Additionally, it showcases an inference demo leveraging a YOLOv5s model fine-tuned for enhanced truck detection accuracy. This demonstration serves as a practical example of the model's improved performance in identifying trucks.