Blackboard REST MVP #1752
Closed
Blackboard REST MVP #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
export; The property 'selected' can't be undefined or null so remove the question mark; Move the styling for the list to the MUI List and then remove the redundant div; Give proper value to the ListItem key; Remove redundant variable 'checked'
Add JSDoc to this component and its props interface, and react hooks; Remove redundant function 'updateFilterName'; Remove redundant expressions for MUI Dialog; Remove helperText from the Filter name textfield.
of the Owner filter and Date modified filter of it; Combine two react hooks into one as they have identical dependencies; Move the declaration of two variables to a better place; Make the logic of the if statement in 'save' simpler; Remove two redundant functions 'setOwnerFilter' and 'setDateModifiedFilter'; Give a proper value to the MUI ListItem key attribute; Move the use of 'MimeTypeFilterEditingDialog' above the save button; Remove unused code.
Remove repeated array operations; Make clearer comments;
Simplify function 'vaidateMimeTypeName'.
then display a dialog to show all the error messages. MUI snackbar does not support multiple lines of texts so create a dialog for this case. Create an interface to represent the data included in the 207 response body.
Split up the batch update test and remove unnecessary asserts.
…_controls_in_settings_list
…_wider_controls_in_settings_list Change styles to allow SettingsListControl to support wider controls
This reverts commit 8674b65.
…che-2 ci: upgrade github cache action to version 2
this would allow for catching new potential licensing issues, failing the build if a new package with an unknown/unapproved license is added. also adds 0BSD, which is re-packaged ISC license, used by tslib.
…known-packages test: ignore known issue packages
|
Looks like the build error is an unrelated UI issue that is present in |
…y_import_styles Use only @material-ui/core/styles and move away from standalone @material/styles
…ate-change-version-strategy-for-tough-cookie chore: change version strategy for tough cookie
…ymce-vulnerability fix(deps): update dependency tinymce to v5.2.2 [security]
…ELLA into feature/821-bb-rest-3lo
|
In the attempt to help resolve the build issues by rebasing / merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Part of the Blackboard REST MVP ( looking to keep the number of commits into Dev small since I'll likely need to backport this into 2019.1 / 2019.2 / 2020.0 ) ( https://github.com/openequella/openEQUELLA/issues?q=is%3Aopen+label%3A%22Integration+-+Bb+LTI%2FREST%22+milestone%3A2020.2 ):
Included:
Need to finish out: