This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
restore authorship for clique engine #10530
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes for broken spec code, sync speedup
fix broken sync
Merge updates downstream
merge upstream updates downstream
some preliminary cleanup
ethcore: fix goerli chain spec
…5-backport-downstream
backport downstream
prevent SystemTime panics
grumble(on_seal_block): make `&mut` to avoid clone
backports from upstream
docs: remove eth hf references in spec
client: warn on unable to get mut ref for engine for shutdown
Delete .travis.yml
fix(CliqueStepService): replace `RwLock` with `AtomicBool`
fix(clique): use `Duration::as_millis`
Clean up some Clique documentation
soc1c
added
A2-insubstantial 👶
Pull request requires no code review (e.g., a sub-repository hash update).
A4-clasignoffneeded 📛
Pull request requires author to sign off on CLA before review/merge can begin.
M4-core ⛓
Core client code / Rust.
M2-config 📂
Chain specifications and node configurations.
labels
Mar 27, 2019
It looks like @soc1c hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
sorpaas
approved these changes
Mar 27, 2019
Either add them as co-authors to the commit message (https://help.github.com/en/articles/creating-a-commit-with-multiple-authors) or rebase this so we only get one commit from each. |
managed to amend the commit on master: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A2-insubstantial 👶
Pull request requires no code review (e.g., a sub-repository hash update).
A4-clasignoffneeded 📛
Pull request requires author to sign off on CLA before review/merge can begin.
M2-config 📂
Chain specifications and node configurations.
M4-core ⛓
Core client code / Rust.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref "ethcore: add clique engine" #9981 - was authored by @thefallentree @jwasinger @niklasad1 @HCastano and we would like to retain the authorship.
this pull request does not introduce any changes and should not me squash-merged.
@thefallentree @jwasinger if you could please sign the Parity CLA, please: https://cla.parity.io