Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icloud] Add german translation #10164

Merged
merged 1 commit into from
Feb 19, 2021
Merged

[icloud] Add german translation #10164

merged 1 commit into from
Feb 19, 2021

Conversation

Pantastisch
Copy link
Contributor

@Pantastisch Pantastisch commented Feb 15, 2021

Signed-off-by: Panagiotis Doulgeris panagiotis.doulgeris@outlook.com

Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fwolter
Copy link
Member

fwolter commented Feb 18, 2021

The sign-off message must contain your realname and a valid mail address. See https://www.openhab.org/docs/developer/contributing.html#sign-your-work

@Pantastisch
Copy link
Contributor Author

The sign-off message must contain your realname and a valid mail address. See https://www.openhab.org/docs/developer/contributing.html#sign-your-work

Done!

@fwolter
Copy link
Member

fwolter commented Feb 18, 2021

Did you push your change?

Signed-off-by: Panagiotis Doulgeris panagiotis.doulgeris@outlook.com
Signed-off-by: Pantastisch <45369229+Pantastisch@users.noreply.github.com>
@Pantastisch
Copy link
Contributor Author

Did you push your change?

Hope it looks better now.

In my commit message are now two sign-off messages by myself.
One with my git account, one with my personal data.

How do I get rid of the git accounts one?
Does it interfere with the contribution guideline?

@fwolter
Copy link
Member

fwolter commented Feb 19, 2021

That's fine, thanks!

@fwolter fwolter merged commit 1c5f0d1 into openhab:main Feb 19, 2021
@fwolter fwolter added this to the 3.1 milestone Feb 19, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
Signed-off-by: Panagiotis Doulgeris panagiotis.doulgeris@outlook.com
Signed-off-by: Pantastisch <45369229+Pantastisch@users.noreply.github.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Signed-off-by: Panagiotis Doulgeris panagiotis.doulgeris@outlook.com
Signed-off-by: Pantastisch <45369229+Pantastisch@users.noreply.github.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Panagiotis Doulgeris panagiotis.doulgeris@outlook.com
Signed-off-by: Pantastisch <45369229+Pantastisch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants