-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[senechome] Fix for Senec firmware update #15535
Conversation
Are you sure about the removal of the "STATISTIC" block? Update: querying lala.cgi with {"DEBUG":{}} returns all sections and that list still contains "STATISTIC", so maybe just a bug that the returned block is empty? |
Another update: |
Will solve issue #15524 |
This PR seems also to remove 7 channels. Why isn't it mentioned in PR description? |
Yes, Senec unfortunately removed that values from the local web UI. Therefore this cannels doen't work for a while. It's basically a cleanup. |
...hab.binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeApi.java
Outdated
Show resolved
Hide resolved
...binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandler.java
Outdated
Show resolved
Hide resolved
...hab.binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeApi.java
Show resolved
Hide resolved
....senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandlerFactory.java
Outdated
Show resolved
Hide resolved
....senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandlerFactory.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
* Add support for Move 2 Resolves openhab#15702 --------- Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
* Solves issue openhab#15684 * Removing excessive usage of inline typecast --------- Signed-off-by: clinique <gael@lhopital.org>
* Convert to OH jetty HttpClient * Adds a Stack for HttpClient storage * Add synchronized to prevent exception * fix binding * Stop stack on close * Resolves exception on registring forward actions * Reduces client count to 5 to align to expected thread pool limit of 5 --------- Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com> Co-authored-by: Mark Herwege <mark.herwege@telenet.be>
* Adding the possibility to disable websocket listening. This is set up in order to ease debugging of the "Erreur Interne" issue. * Enhancing websocket work with recurrent deconnection, simplification of listeners handling * refactored function name * Fixed the name of the channel where the refresh command is sent. * Solving SAT issues * Corrected doc error * Added properties * Removed gson 2.10 now that it is included into core. --------- Signed-off-by: clinique <gael@lhopital.org>
If the client is not stopped it will not be garbage collected because the ShutdownThread keeps a reference to the client so it can be stopped on shutdowns. See: https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-websocket/websocket-client/src/main/java/org/eclipse/jetty/websocket/client/WebSocketClient.java#L420-L433 Signed-off-by: Wouter Born <github@maindrain.net>
* [jythonscripting] Add a note not to use jython * [jythonscripting] Mark as deprecated --------- Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
…penhab#15720) This reverts commit 72622a1. Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
The dependency change in openhab#15659 caused slf4j to be embedded into the bundle. As a result the bundle no longer uses Pax Logging so it cannot find an SLF4J provider and logs the following when it is installed: SLF4J: No SLF4J providers were found. SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details. Signed-off-by: Wouter Born <github@maindrain.net>
… in order (openhab#15530) Signed-off-by: Anton Hattendorf <anton@hattendoerfer.de>
If the client is not stopped it will not be garbage collected because the ShutdownThread keeps a reference to the client so it can be stopped on shutdowns. See: https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-websocket/websocket-client/src/main/java/org/eclipse/jetty/websocket/client/WebSocketClient.java#L420-L433 Signed-off-by: Wouter Born <github@maindrain.net>
* Fix problem with DPT 251.600. In the old implementation the datatype was implemented with byte 0-255. The DPT 251.600 is defined with 0-100%, change this from byte to PercentType. Signed-off-by: Marco Mueller <marco@ms.mueller.ch>
Upgrades H2 database from 1.4.191 to 2.2.224. Add ';NON_KEYWORDS=VALUE' to the JDBC URL because the add-on uses 'value' (which is also a keyword) as column name. Also fixes some queries used by the command extension because H2 always uses upper case table names. For the change log, see: https://h2database.com/html/changelog.html For migration notes, see: https://h2database.com/html/migration-to-v2.html Fixes openhab#13115 Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
I think the PR got fixed; All the excess reviewers got removed, review comments are addressed etc. Maybe @lolodomo needs anothe review pass, but nothing you can do at the moment to speed up merging. |
bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are new and final review comments
....senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandlerFactory.java
Outdated
Show resolved
Hide resolved
....senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandlerFactory.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/i18n/senechome.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
…F/thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Robert D. <querdenker2k@gmx.de>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
DCO is KO probably due to wrong usage of git rebase. I am going to squash everything and keep the proper sign-off-by. |
Probably you only need to cleanup the commit message and the squashed commit should look like https://github.com/openhab/openhab-addons/pull/15535/files |
A real nightmare, the merge message was containing probably several hundreds of lines. I just kept two lines. |
Maybe @querdenker2k can have a look at the linked community post in the PR template next time:
|
* Fix for Senec update Signed-off-by: querdenker2k <querdenker2k@gmx.de>
* Fix for Senec update Signed-off-by: querdenker2k <querdenker2k@gmx.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Senec updated the Firmware which changes the protocol from http to https and disabled historic data access.
I added a new thing config parameter useHttp for legacy usage if some modules are not updated.
Edit: