-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Adds latency metrics for ClusterState Appliers and Listeners #13755
Conversation
* Adds latency metrics for ClusterState Appliers and Listeners Signed-off-by: Harsh Garg <gkharsh@amazon.com> (cherry picked from commit a254aa9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
❕ Gradle check result for 6d23c1d: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Detect breaking changes workflow is correctly catching an issue here - This breaks the ctor for ClusterService which is marked as api - ex. https://github.com/opensearch-project/asynchronous-search/pull/576/files |
@mch2 ClusterService, MasterService, AllocationService, for all these classes singleton objects are created in Node.java and then injected all throughout. How do you suggest we can handle constructor changes here? |
This PR is stalled because it has been open for 30 days with no activity. |
apologies @shwetathareja for the late reply - seems this has been resolved with overloading the ctors in #13926. I think we can merge this backport with a rebase? |
Another backport PR was merged to address this (#14118). |
Backport a254aa9 from #12333.