Create React component for Integrations Setup UI #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Let it be known at on this day, with this commit, I have truly grokked why we don't use `any` in typescript. Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
penghuo,
seankao-az and
anirudha
as code owners
anirudha
approved these changes
Sep 18, 2023
YANG-DB
approved these changes
Sep 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
* Stub catalog reader interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic catalog functionality to new catalog reader Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Generalize Result type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert backend to use catalog reader (unstable) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair tests for integrations class (unstable) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor repository for new integration interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix outer repository and backend tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for sample data Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add CatalogReader JavaDocs Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair integrations builder Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove extra commented test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unnecessary log statement Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair getSchemas behavior to return correct type Let it be known at on this day, with this commit, I have truly grokked why we don't use `any` in typescript. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for getSchemas Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for asset and sample data backend methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Break flyout validation methods out of constructing method Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for extracted flyout methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch validation method to use ValidationResult Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Swap out flyout for hello-world setup page Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic step incrementing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic field skeleton for each step Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add a cancel button Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add config type to developing form Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Flatten integration config Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add sample data table modal Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add toggle for standard and advanced asset config Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor major class names Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * (WIP) begin refactoring functionality into adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Finish migrating functionality to data adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Rename integration types for more clarity Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor component usage Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Connect forms to config state Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix filetype selector Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove hardcoded name in path Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Write one snapshot test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add more tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix test naming Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update obsolete snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 8f60eae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
pjfitzgibbons
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Stub catalog reader interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic catalog functionality to new catalog reader Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Generalize Result type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert backend to use catalog reader (unstable) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair tests for integrations class (unstable) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor repository for new integration interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix outer repository and backend tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for sample data Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add CatalogReader JavaDocs Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair integrations builder Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove extra commented test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unnecessary log statement Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair getSchemas behavior to return correct type Let it be known at on this day, with this commit, I have truly grokked why we don't use `any` in typescript. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for getSchemas Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for asset and sample data backend methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Break flyout validation methods out of constructing method Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for extracted flyout methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch validation method to use ValidationResult Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Swap out flyout for hello-world setup page Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic step incrementing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic field skeleton for each step Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add a cancel button Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add config type to developing form Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Flatten integration config Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add sample data table modal Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add toggle for standard and advanced asset config Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor major class names Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * (WIP) begin refactoring functionality into adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Finish migrating functionality to data adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Rename integration types for more clarity Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor component usage Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Connect forms to config state Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix filetype selector Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove hardcoded name in path Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Write one snapshot test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add more tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix test naming Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update obsolete snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
derek-ho
pushed a commit
to derek-ho/dashboards-observability
that referenced
this pull request
Oct 4, 2023
…1009) * Stub catalog reader interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic catalog functionality to new catalog reader Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Generalize Result type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert backend to use catalog reader (unstable) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair tests for integrations class (unstable) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor repository for new integration interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix outer repository and backend tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for sample data Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add CatalogReader JavaDocs Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair integrations builder Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove extra commented test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unnecessary log statement Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair getSchemas behavior to return correct type Let it be known at on this day, with this commit, I have truly grokked why we don't use `any` in typescript. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for getSchemas Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for asset and sample data backend methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Break flyout validation methods out of constructing method Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for extracted flyout methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch validation method to use ValidationResult Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Swap out flyout for hello-world setup page Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic step incrementing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic field skeleton for each step Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add a cancel button Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add config type to developing form Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Flatten integration config Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add sample data table modal Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add toggle for standard and advanced asset config Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor major class names Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * (WIP) begin refactoring functionality into adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Finish migrating functionality to data adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Rename integration types for more clarity Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor component usage Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Connect forms to config state Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix filetype selector Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove hardcoded name in path Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Write one snapshot test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add more tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix test naming Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update obsolete snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
pjfitzgibbons
added a commit
that referenced
this pull request
Oct 5, 2023
* Update mocha (#960) * added code for the change of design of the sidebar, fixed overriding … (#928) * Refactor add_integration_flyout to break out nested methods (#956) * [Log Explorer] Remove top level tabs (#970) * Explorer's timeheader & color change (#959) * Update caching (#965) * Move query_utils to /public (#983) * Remove Zeppelin Parser from Notebook (#985) * Explorer empty bucket (#990) * refactored classnames for sidebar (#933) * Refactor Integrations Backend to abstract IO (#947) * Create React component for Integrations Setup UI (#1009) * Create Data sources plugin with Manage Datasources Flow (#1035) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * adjust explorer chart color and spacing (#1051) * Configure S3 datasource flow (#1049) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * modified explorer data grid to follow discover look and feel (#1041) * Create prometheus datasource flow (#1054) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * added design changes for sidebar (#1061) * updated snapshots (#1062) * Update UI for integrations setup (#1052) * Data sources UI improvements (#1059) * adding redirection to datasources (#1063) * Move convertDateTime, refactor query_utils (#1064) * Setup S3 connection with integrations (#1057) * Use approved svg from UX (#1066) * Fix missing import 'moment' on query_utils. (#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
* Update mocha (opensearch-project#960) * added code for the change of design of the sidebar, fixed overriding … (opensearch-project#928) * Refactor add_integration_flyout to break out nested methods (opensearch-project#956) * [Log Explorer] Remove top level tabs (opensearch-project#970) * Explorer's timeheader & color change (opensearch-project#959) * Update caching (opensearch-project#965) * Move query_utils to /public (opensearch-project#983) * Remove Zeppelin Parser from Notebook (opensearch-project#985) * Explorer empty bucket (opensearch-project#990) * refactored classnames for sidebar (opensearch-project#933) * Refactor Integrations Backend to abstract IO (opensearch-project#947) * Create React component for Integrations Setup UI (opensearch-project#1009) * Create Data sources plugin with Manage Datasources Flow (opensearch-project#1035) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * adjust explorer chart color and spacing (opensearch-project#1051) * Configure S3 datasource flow (opensearch-project#1049) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * modified explorer data grid to follow discover look and feel (opensearch-project#1041) * Create prometheus datasource flow (opensearch-project#1054) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * added design changes for sidebar (opensearch-project#1061) * updated snapshots (opensearch-project#1062) * Update UI for integrations setup (opensearch-project#1052) * Data sources UI improvements (opensearch-project#1059) * adding redirection to datasources (opensearch-project#1063) * Move convertDateTime, refactor query_utils (opensearch-project#1064) * Setup S3 connection with integrations (opensearch-project#1057) * Use approved svg from UX (opensearch-project#1066) * Fix missing import 'moment' on query_utils. (opensearch-project#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 171acde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of a larger campaign to improve the integrations setup and connect it with Flint, this PR works to create the skeleton page for that UI. The PR is still a work in progress, it's missing testing and would benefit from some refactoring, but it's at least in a state that's ready for initial feedback.
Depends on #947
Demo Video
Screen.Recording.2023-09-15.at.2.56.18.PM.mov
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.