modified explorer data grid to follow discover look and feel #1041

paulstn · 2023-09-21T17:49:19Z

Description

Adds data grid to log explorer that has the look and feel of the new Discover data grid

Issues Resolved

Look and feel changes to Explorer Data Grid.
Known needed changes (p1-2 items): sidebar field order implementation, surrounding events implementation

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

…field storing Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

…ds-observability into explorer-data-grid

codecov · 2023-09-22T21:40:44Z

Codecov Report

Merging #1041 (c1cc79f) into main (a844594) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1041   +/-   ##
=======================================
  Coverage   44.42%   44.43%           
=======================================
  Files         325      324    -1     
  Lines       19055    19089   +34     
  Branches     4572     4566    -6     
=======================================
+ Hits         8465     8482   +17     
- Misses      10547    10564   +17     
  Partials       43       43

Flag	Coverage Δ
dashboards-observability	`44.43% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 32 files with indirect coverage changes

public/components/event_analytics/explorer/sidebar/sidebar.tsx

public/components/event_analytics/explorer/events_views/doc_flyout.tsx

public/components/event_analytics/explorer/__tests__/data_grid.test.tsx

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

derek-ho · 2023-09-26T14:58:45Z

Can you add a screenshot of the new feel?

paulstn · 2023-09-26T16:28:57Z

Can you add a screenshot of the new feel?

added to description

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

joshuali925

minor comments

public/components/event_analytics/explorer/events_views/data_grid.tsx

common/types/explorer.ts

public/components/event_analytics/explorer/events_views/data_grid.tsx

public/components/event_analytics/explorer/events_views/docViewRow.tsx

test/event_analytics_constants.ts

…ds-observability into explorer-data-grid

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

public/components/event_analytics/utils/__tests__/utils.test.tsx

mengweieric

minor comments

public/components/event_analytics/explorer/events_views/data_grid.tsx

public/components/event_analytics/explorer/sidebar/sidebar.tsx

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

…rch-project#1041) * initial data grid column change with hardcoded vals Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic render cell data added Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added memoization for all components and redid cell rendering Signed-off-by: Paul Sebastian <paulstn@amazon.com> * allow for any kind of field to be shown Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic pagination only with queried data Signed-off-by: Paul Sebastian <paulstn@amazon.com> * sorting and pagination effect onto query support Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fully functional flyout Signed-off-by: Paul Sebastian <paulstn@amazon.com> * removed unneeded code and fixed typing errors Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed field sorting/paginating issue with sidebar integration and expfield storing Signed-off-by: Paul Sebastian <paulstn@amazon.com> * code cleanup Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed a lot of tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * reduce sidebar code redundancy Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove commented code Signed-off-by: Paul Sebastian <paulstn@amazon.com> * test constant Signed-off-by: Paul Sebastian <paulstn@amazon.com> * flyout testing code Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed small sidebar init issue Signed-off-by: Paul Sebastian <paulstn@amazon.com> * changed default page size from 25 to 100 Signed-off-by: Paul Sebastian <paulstn@amazon.com> * updated snapshot Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small changes + source column prettied + snapshot Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small todos and code coverage change Signed-off-by: Paul Sebastian <paulstn@amazon.com> * moved redo query to util function Signed-off-by: Paul Sebastian <paulstn@amazon.com> * redoQuery testing Signed-off-by: Paul Sebastian <paulstn@amazon.com> * redoQuery testing Signed-off-by: Paul Sebastian <paulstn@amazon.com> * redoQuery testing Signed-off-by: Paul Sebastian <paulstn@amazon.com> * modified redo func in utils test Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small pr changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com>

* Update mocha (#960) * added code for the change of design of the sidebar, fixed overriding … (#928) * Refactor add_integration_flyout to break out nested methods (#956) * [Log Explorer] Remove top level tabs (#970) * Explorer's timeheader & color change (#959) * Update caching (#965) * Move query_utils to /public (#983) * Remove Zeppelin Parser from Notebook (#985) * Explorer empty bucket (#990) * refactored classnames for sidebar (#933) * Refactor Integrations Backend to abstract IO (#947) * Create React component for Integrations Setup UI (#1009) * Create Data sources plugin with Manage Datasources Flow (#1035) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * adjust explorer chart color and spacing (#1051) * Configure S3 datasource flow (#1049) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * modified explorer data grid to follow discover look and feel (#1041) * Create prometheus datasource flow (#1054) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * added design changes for sidebar (#1061) * updated snapshots (#1062) * Update UI for integrations setup (#1052) * Data sources UI improvements (#1059) * adding redirection to datasources (#1063) * Move convertDateTime, refactor query_utils (#1064) * Setup S3 connection with integrations (#1057) * Use approved svg from UX (#1066) * Fix missing import 'moment' on query_utils. (#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com>

* Update mocha (opensearch-project#960) * added code for the change of design of the sidebar, fixed overriding … (opensearch-project#928) * Refactor add_integration_flyout to break out nested methods (opensearch-project#956) * [Log Explorer] Remove top level tabs (opensearch-project#970) * Explorer's timeheader & color change (opensearch-project#959) * Update caching (opensearch-project#965) * Move query_utils to /public (opensearch-project#983) * Remove Zeppelin Parser from Notebook (opensearch-project#985) * Explorer empty bucket (opensearch-project#990) * refactored classnames for sidebar (opensearch-project#933) * Refactor Integrations Backend to abstract IO (opensearch-project#947) * Create React component for Integrations Setup UI (opensearch-project#1009) * Create Data sources plugin with Manage Datasources Flow (opensearch-project#1035) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * adjust explorer chart color and spacing (opensearch-project#1051) * Configure S3 datasource flow (opensearch-project#1049) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * modified explorer data grid to follow discover look and feel (opensearch-project#1041) * Create prometheus datasource flow (opensearch-project#1054) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * added design changes for sidebar (opensearch-project#1061) * updated snapshots (opensearch-project#1062) * Update UI for integrations setup (opensearch-project#1052) * Data sources UI improvements (opensearch-project#1059) * adding redirection to datasources (opensearch-project#1063) * Move convertDateTime, refactor query_utils (opensearch-project#1064) * Setup S3 connection with integrations (opensearch-project#1057) * Use approved svg from UX (opensearch-project#1066) * Fix missing import 'moment' on query_utils. (opensearch-project#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 171acde)

paulstn added 12 commits September 14, 2023 17:20

initial data grid column change with hardcoded vals

219b0ed

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

basic render cell data added

bcb1501

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

added memoization for all components and redid cell rendering

64428e5

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

allow for any kind of field to be shown

1a56df0

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

basic pagination only with queried data

612a4c1

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

sorting and pagination effect onto query support

6c7a5a0

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

fully functional flyout

017f38c

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

removed unneeded code and fixed typing errors

86ab883

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

fixed field sorting/paginating issue with sidebar integration and exp…

b559fb5

…field storing Signed-off-by: Paul Sebastian <paulstn@amazon.com>

code cleanup

92f05c7

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

fixed a lot of tests

d060673

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Merge branch 'main' of https://github.com/opensearch-project/dashboar…

47921b2

…ds-observability into explorer-data-grid

paulstn marked this pull request as ready for review September 22, 2023 21:23

paulstn requested review from pjfitzgibbons, ps48, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsi-amazon, Swiddis, penghuo, seankao-az and anirudha as code owners September 22, 2023 21:23

ps48 reviewed Sep 22, 2023

View reviewed changes

public/components/event_analytics/explorer/sidebar/sidebar.tsx Outdated Show resolved Hide resolved

ps48 reviewed Sep 22, 2023

View reviewed changes

public/components/event_analytics/explorer/events_views/doc_flyout.tsx Outdated Show resolved Hide resolved

ps48 reviewed Sep 22, 2023

View reviewed changes

public/components/event_analytics/explorer/__tests__/data_grid.test.tsx Outdated Show resolved Hide resolved

paulstn added 5 commits September 22, 2023 15:35

reduce sidebar code redundancy

ee4fe5e

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

remove commented code

b94cec2

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

test constant

38aea1b

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

flyout testing code

6a12fba

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

fixed small sidebar init issue

6ac7259

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn requested a review from ps48 September 26, 2023 01:17

paulstn added 2 commits September 26, 2023 09:58

changed default page size from 25 to 100

66e2206

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

updated snapshot

fa3c3ac

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn changed the title ~~Explorer data grid~~ modified explorer data grid to follow discover look and feel Sep 26, 2023

joshuali925 reviewed Sep 26, 2023

View reviewed changes

paulstn added 2 commits September 26, 2023 14:35

Merge branch 'main' of https://github.com/opensearch-project/dashboar…

221f65a

…ds-observability into explorer-data-grid

small changes + source column prettied + snapshot

a226c81

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn requested a review from joshuali925 September 26, 2023 23:06

paulstn added 5 commits September 27, 2023 11:16

small todos and code coverage change

d1a8b35

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

moved redo query to util function

fcf676b

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

redoQuery testing

226b4a7

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

redoQuery testing

8576bf6

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

redoQuery testing

0387d7e

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

joshuali925 reviewed Sep 28, 2023

View reviewed changes

public/components/event_analytics/utils/__tests__/utils.test.tsx Outdated Show resolved Hide resolved

mengweieric approved these changes Sep 28, 2023

View reviewed changes

public/components/event_analytics/explorer/events_views/data_grid.tsx Show resolved Hide resolved

public/components/event_analytics/explorer/sidebar/sidebar.tsx Outdated Show resolved Hide resolved

paulstn added 2 commits September 28, 2023 16:23

modified redo func in utils test

48861a1

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

small pr changes

c1cc79f

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

joshuali925 approved these changes Sep 28, 2023

View reviewed changes

ps48 merged commit ae399e2 into opensearch-project:main Sep 29, 2023
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modified explorer data grid to follow discover look and feel #1041

modified explorer data grid to follow discover look and feel #1041

paulstn commented Sep 21, 2023 •

edited

Loading

codecov bot commented Sep 22, 2023 •

edited

Loading

derek-ho commented Sep 26, 2023

paulstn commented Sep 26, 2023

joshuali925 left a comment

mengweieric left a comment

modified explorer data grid to follow discover look and feel #1041

modified explorer data grid to follow discover look and feel #1041

Conversation

paulstn commented Sep 21, 2023 • edited Loading

Description

Issues Resolved

Check List

codecov bot commented Sep 22, 2023 • edited Loading

Codecov Report

derek-ho commented Sep 26, 2023

paulstn commented Sep 26, 2023

joshuali925 left a comment

Choose a reason for hiding this comment

mengweieric left a comment

Choose a reason for hiding this comment

paulstn commented Sep 21, 2023 •

edited

Loading

codecov bot commented Sep 22, 2023 •

edited

Loading