Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker compose v2, add nodes stats global io usage struct, tests against opesnearch 2.13 #506

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

Jakob3xD
Copy link
Collaborator

@Jakob3xD Jakob3xD commented Apr 3, 2024

Description

Issues Resolved

Closes #505

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Jakob3xD added 2 commits April 3, 2024 09:53
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.26%. Comparing base (e0278ab) to head (2c4b859).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   57.26%   57.26%           
=======================================
  Files         315      315           
  Lines        9823     9823           
=======================================
  Hits         5625     5625           
  Misses       2904     2904           
  Partials     1294     1294           
Flag Coverage Δ
integration 50.80% <ø> (ø)
unit 12.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
opensearchapi/api_nodes-stats.go 100.00% <ø> (ø)

Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
@Jakob3xD Jakob3xD changed the title Add nodes stats global io usage struct Use docker compose v2, add nodes stats global io usage struct, tests against opesnearch 2.13 Apr 3, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are unrelated things, should be separate PRs, but feel free to merge if you really don't want the extra work :)

@Jakob3xD Jakob3xD merged commit 3b901c7 into opensearch-project:main Apr 3, 2024
55 checks passed
@Jakob3xD Jakob3xD deleted the jh-nodes-stats branch April 3, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Add missing global io usage field for nodes stats
2 participants