Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Disable codecov from failing CI if there is an upload issue #3379

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 6d78bce from #3353.

### Description
Seeing a ton of CI failures due to code coverage upload failures. I'd
like to fix this - but I'd rather keep the builds flowing in until we
have a better solution.

E.g:
https://github.com/opensearch-project/security/actions/runs/6153593099/job/16697726519?pr=3339

- Related #2649

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 6d78bce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #3379 (568bd4b) into 2.x (c00ddd0) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3379      +/-   ##
============================================
- Coverage     64.10%   64.08%   -0.02%     
- Complexity     3365     3366       +1     
============================================
  Files           256      256              
  Lines         19515    19515              
  Branches       3297     3297              
============================================
- Hits          12510    12507       -3     
- Misses         5362     5364       +2     
- Partials       1643     1644       +1     

see 4 files with indirect coverage changes

@peternied peternied merged commit d6ad731 into 2.x Sep 18, 2023
99 of 101 checks passed
@peternied peternied deleted the backport/backport-3353-to-2.x branch September 18, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants