OCPBUGS-66045: enhance cy.login flow to close guided tour properly

[yapei]

The element loading order in login flow is: masthead, guided tour, then dashboard(for cluster-admin user) or projects list page(normal user)
So only wait for the username in masthead is not reliable and that's why guided tour is not closed properly in many tests

• updated validate steps in cy.login flow to wait for more specific elements to make sure guided tour is present

About loading order, this video is a good reference

login-loading-order.mov

[openshift-ci-robot]

@yapei: This pull request references Jira Issue OCPBUGS-66045, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The element loading order in login flow is: masthead, guided tour, then dashboard(for cluster-admin user) or projects list page(normal user)

About loading order, this video is a good reference

login-loading-order-provement.mp4

so only wait for the username in masthead is not reliable and that's why guided tour is not closed properly in many tests

• updated validate steps in cy.login flow to wait for more specific elements to make sure guided tour is present

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yapei.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@yapei: This pull request references Jira Issue OCPBUGS-66045, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The element loading order in login flow is: masthead, guided tour, then dashboard(for cluster-admin user) or projects list page(normal user)

About loading order, this video is a good reference

login-loading-order-provement.mp4

so only wait for the username in masthead is not reliable and that's why guided tour is not closed properly in many tests

• updated validate steps in cy.login flow to wait for more specific elements to make sure guided tour is present

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Walkthrough

Adds UI assertions to the Cypress login flow that check main content visibility and branch assertions by username; adds assertions on the Alertmanager receiver edit page to verify receiver-name and save-changes are visible after navigation.

Changes

Cohort / File(s)	Summary
Cypress Login Validation Assertions frontend/packages/integration-tests-cypress/support/login.ts	After confirming the user dropdown exists, asserts that the main element is visible; adds a username branch: if the username is kubeadmin assert getting-started is visible, otherwise assert loading-box__loaded exists.
Alertmanager Edit Page Assertions frontend/packages/integration-tests-cypress/views/alertmanager.ts	visitEditPage now asserts visibility of receiver-name and save-changes after navigating to the receiver edit page.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify the added selectors (main, getting-started, loading-box__loaded, receiver-name, save-changes, user dropdown) are stable and not flaky.
• Confirm the username branching covers test users and does not mask real failures.
• Check wait/timing behavior around the new assertions to avoid intermittent test failures.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@yapei: This pull request references Jira Issue OCPBUGS-66045, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

The element loading order in login flow is: masthead, guided tour, then dashboard(for cluster-admin user) or projects list page(normal user)
So only wait for the username in masthead is not reliable and that's why guided tour is not closed properly in many tests

• updated validate steps in cy.login flow to wait for more specific elements to make sure guided tour is present

About loading order, this video is a good reference

login-loading-order.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yapei.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@yapei: This pull request references Jira Issue OCPBUGS-66045, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

The element loading order in login flow is: masthead, guided tour, then dashboard(for cluster-admin user) or projects list page(normal user)
So only wait for the username in masthead is not reliable and that's why guided tour is not closed properly in many tests

• updated validate steps in cy.login flow to wait for more specific elements to make sure guided tour is present

About loading order, this video is a good reference

login-loading-order.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yapei]

tests/cluster-settings/alertmanager/receivers/pagerduty.cy.ts is flaky

creates and edits PagerDuty Receiver correctly: Alertmanager: PagerDuty Receiver Form creates and edits PagerDuty Receiver correctly 

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between ca8239a and 11536fb.

📒 Files selected for processing (1)

• frontend/packages/integration-tests-cypress/views/alertmanager.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/packages/integration-tests-cypress/views/alertmanager.ts

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

frontend/packages/integration-tests-cypress/views/alertmanager.ts (1)

82-86: Explicit waits after visiting edit page look good

Asserting the presence of receiver-name and save-changes right after cy.visit is a solid replacement for the previous long timeout and should reduce flakiness by ensuring the edit page has actually loaded before further actions.

If you see any remaining flakiness around rendering, you could tighten this later with .should('be.visible'), but the current checks are already reasonable for confirming navigation.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 8f9784c and faf37df.

📒 Files selected for processing (1)

• frontend/packages/integration-tests-cypress/views/alertmanager.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/packages/integration-tests-cypress/views/alertmanager.ts

[jhadvig]

Thank you @yapei
/lgtm
/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yapei]

/retest-required

[yapei]

another flaky

"before all" hook for "test Dashboard Card nav item": Demo dynamic plugin test "before all" hook for "test Dashboard Card nav item"

/retest-required

[yapei]

/verified by ci

[openshift-ci-robot]

@yapei: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yapei]

/retest-required

[openshift-ci]

@yapei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	faf37df	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 971f0fa and 2 for PR HEAD faf37df in total

[jhadvig]

Overriding the tests due to the high flakiness
/override ci/prow/e2e-gcp-console

@yapei FYI

[openshift-ci]

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-gcp-console

Details

In response to this:

Overriding the tests due to the high flakiness
/override ci/prow/e2e-gcp-console

@yapei FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@yapei: Jira Issue Verification Checks: Jira Issue OCPBUGS-66045
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66045 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

The element loading order in login flow is: masthead, guided tour, then dashboard(for cluster-admin user) or projects list page(normal user)
So only wait for the username in masthead is not reliable and that's why guided tour is not closed properly in many tests

• updated validate steps in cy.login flow to wait for more specific elements to make sure guided tour is present

About loading order, this video is a good reference

login-loading-order.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.21.0-0.nightly-2025-12-08-112148