Revert "OCPBUGS-66045: enhance cy.login flow to close guided tour properly"

[rhamilto]

Reverts #15776 in order to unblock CI

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-66045, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #15776 in order to unblock CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

Removes runtime UI assertions from two Cypress test utility files. Login validation no longer checks main element visibility or username-conditional states. Alertmanager edit page navigation skips validation of receiver-name field and save-changes button presence.

Changes

Cohort / File(s)	Change Summary
Cypress Test Suite - Assertion Removals frontend/packages/integration-tests-cypress/support/login.ts, frontend/packages/integration-tests-cypress/views/alertmanager.ts	Removes runtime UI state validations. Login validate() eliminates main element visibility and username-conditional checks (kubeadmin getting-started, others loading-box). Alertmanager visitEditPage removes receiver-name field and save-changes button existence assertions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that removing main element visibility check in login validation does not mask critical UI initialization failures
• Confirm that removing conditional kubeadmin vs. standard user assertions does not affect test coverage for distinct login paths
• Ensure alertmanager edit page navigation changes do not hide form submission or receiver configuration issues

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch revert-15776-e2e-tests

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between d93076f and b10cbcc.

📒 Files selected for processing (2)

• frontend/packages/integration-tests-cypress/support/login.ts (0 hunks)
• frontend/packages/integration-tests-cypress/views/alertmanager.ts (0 hunks)

💤 Files with no reviewable changes (2)

• frontend/packages/integration-tests-cypress/support/login.ts
• frontend/packages/integration-tests-cypress/views/alertmanager.ts

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rhamilto]

/jira refresh

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-66045, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/verified by ci

[openshift-ci-robot]

@logonoff: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d93076f and 2 for PR HEAD b10cbcc in total

[vikram-raj]

/retest

[jhadvig]

manually overriding to unblock the merge queue

/override ci/prow/e2e-gcp-console

[openshift-ci]

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-gcp-console

Details

In response to this:

manually overriding to unblock the merge queue

/override ci/prow/e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-66045
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66045 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Reverts #15776 in order to unblock CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.