OCPBUGS-66045: disable guided tour when cypress is running #15841
+45
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@logonoff: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughAdds detection for an "INTEGRATION_TEST" feature flag (based on navigator.userAgent) and registers an exposed handler; marks guided-tour extensions disallowed for that flag. Removes the exported guidedTour utility and deletes many test imports and calls to guidedTour.close(). Adds Cypress userAgent config to multiple integration-test configs. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (90)
💤 Files with no reviewable changes (73)
🚧 Files skipped from review as they are similar to previous changes (13)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (4)
Comment |
openshift-ci
bot
added
component/core
Member
Author
|
/label px-approved |
openshift-ci
bot
added
px-approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
frontend/packages/integration-tests-cypress/tests/app/admission-webhook-warning-notifications.cy.ts (1)
96-96: Fix typo in environment variable value.The value
frontenndappears to be a typo and should likely befrontend.Apply this diff:
- value: frontennd + value: frontend
🧹 Nitpick comments (1)
frontend/packages/integration-tests-cypress/tests/app/auth-multiuser-login.cy.ts (1)
27-27: Align test comment with actual assertionsThis comment says we test that the Developer perspective is the default, but the current assertions only verify the username (the perspective check is commented out below). Consider updating the comment or re-enabling the perspective assertion once the operator PR is in, to avoid confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (90)
frontend/packages/console-app/console-extensions.json(1 hunks)frontend/packages/console-app/package.json(1 hunks)frontend/packages/console-app/src/consts.ts(1 hunks)frontend/packages/console-app/src/features/integration-test.ts(1 hunks)frontend/packages/console-telemetry-plugin/integration-tests/cypress.config.js(1 hunks)frontend/packages/console-telemetry-plugin/integration-tests/support/commands/hooks.ts(0 hunks)frontend/packages/dev-console/console-extensions.json(1 hunks)frontend/packages/dev-console/integration-tests/cypress.config.js(1 hunks)frontend/packages/dev-console/integration-tests/features/getting-started/getting-started-tour-dev-perspective.feature(1 hunks)frontend/packages/dev-console/integration-tests/support/pages/app.ts(0 hunks)frontend/packages/dev-console/integration-tests/support/pages/functions/checkDeveloperPerspective.ts(0 hunks)frontend/packages/dev-console/integration-tests/support/pages/functions/createGitWorkload.ts(0 hunks)frontend/packages/dev-console/integration-tests/support/step-definitions/common/common.ts(0 hunks)frontend/packages/dev-console/integration-tests/support/step-definitions/common/operators.ts(0 hunks)frontend/packages/dev-console/integration-tests/support/step-definitions/customization/configure-perspectives.ts(0 hunks)frontend/packages/dev-console/integration-tests/support/step-definitions/health-checks/add-health-checks-topology-sidebar.ts(0 hunks)frontend/packages/dev-console/integration-tests/support/step-definitions/topology/create-workloads.ts(0 hunks)frontend/packages/helm-plugin/integration-tests/cypress.config.js(1 hunks)frontend/packages/helm-plugin/integration-tests/support/commands/hooks.ts(0 hunks)frontend/packages/helm-plugin/integration-tests/support/step-definitions/common/common.ts(0 hunks)frontend/packages/integration-tests-cypress/cypress.config.js(1 hunks)frontend/packages/integration-tests-cypress/support/admin.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/admission-webhook-warning-notifications.cy.ts(1 hunks)frontend/packages/integration-tests-cypress/tests/app/auth-multiuser-login.cy.ts(1 hunks)frontend/packages/integration-tests-cypress/tests/app/debug-pod.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/demo-dynamic-plugin.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/filtering-and-searching.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/masthead.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/node-terminal.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/overview.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/poll-console-updates.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/resource-log.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/start-job-from-cronjob.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/template.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/app/yaml-editor-settings.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/cluster-settings/oauth.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crd-extensions/console-external-log-link.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/add-storage-crud.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/annotations.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/bulk-create-resources.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/customresourcedefinition.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/environment.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/image-pull-secret.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/namespace-crud.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/other-routes.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/quotas.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/resource-crud.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/roles-rolebindings.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/secrets/add-to-workload.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/secrets/image-pull.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/secrets/key-value.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/secrets/source.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/crud/secrets/webhook.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/dashboards/cluster-dashboard.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/dashboards/project-dashboard.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/events/events.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/favorite/favorite-option.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/i18n/pseudolocalization.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/storage/clone.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/storage/create-storage-class.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/tests/storage/snapshot.cy.ts(0 hunks)frontend/packages/integration-tests-cypress/views/guided-tour.ts(0 hunks)frontend/packages/knative-plugin/integration-tests/cypress.config.js(1 hunks)frontend/packages/knative-plugin/integration-tests/support/commands/hooks.ts(0 hunks)frontend/packages/knative-plugin/integration-tests/support/pages/dev-perspective/common.ts(0 hunks)frontend/packages/knative-plugin/integration-tests/support/pages/dev-perspective/test-serverless-function-page.ts(0 hunks)frontend/packages/knative-plugin/integration-tests/support/step-definitions/serverless/actions-on-knative-revision.ts(0 hunks)frontend/packages/operator-lifecycle-manager/integration-tests-cypress/cypress.config.js(1 hunks)frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/catalog-source-details.cy.ts(0 hunks)frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/create-namespace.cy.ts(0 hunks)frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/deprecated-operator-warnings.cy.ts(0 hunks)frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-hub.cy.ts(0 hunks)frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-install-global.cy.ts(0 hunks)frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-install-single-namespace.cy.ts(0 hunks)frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-uninstall.cy.ts(0 hunks)frontend/packages/shipwright-plugin/integration-tests/cypress.config.js(1 hunks)frontend/packages/shipwright-plugin/integration-tests/support/commands/hooks.ts(0 hunks)frontend/packages/shipwright-plugin/integration-tests/support/step-definitions/common/common.ts(0 hunks)frontend/packages/topology/integration-tests/cypress.config.js(1 hunks)frontend/packages/topology/integration-tests/support/commands/hooks.ts(0 hunks)frontend/packages/topology/integration-tests/support/pages/topology/topology-page.ts(0 hunks)frontend/packages/topology/integration-tests/support/step-definitions/common/topology.ts(0 hunks)frontend/packages/topology/integration-tests/support/step-definitions/topology/chart-view.ts(0 hunks)frontend/packages/topology/integration-tests/support/step-definitions/topology/poddisruptionbdget-warning.ts(0 hunks)frontend/packages/topology/integration-tests/support/step-definitions/topology/resource-quota-warning.ts(0 hunks)frontend/packages/topology/integration-tests/support/step-definitions/topology/workload-sidebar.ts(0 hunks)frontend/packages/webterminal-plugin/integration-tests/cypress.config.js(1 hunks)frontend/packages/webterminal-plugin/integration-tests/support/commands/hooks.ts(0 hunks)frontend/packages/webterminal-plugin/integration-tests/support/step-definitions/common/webTerminal.ts(0 hunks)frontend/packages/webterminal-plugin/integration-tests/support/step-definitions/web-terminal/web-terminal-adminuser.ts(0 hunks)
💤 Files with no reviewable changes (73)
- frontend/packages/helm-plugin/integration-tests/support/commands/hooks.ts
- frontend/packages/integration-tests-cypress/tests/crud/annotations.cy.ts
- frontend/packages/integration-tests-cypress/tests/crud/namespace-crud.cy.ts
- frontend/packages/integration-tests-cypress/tests/app/template.cy.ts
- frontend/packages/integration-tests-cypress/tests/dashboards/project-dashboard.cy.ts
- frontend/packages/integration-tests-cypress/tests/crud/add-storage-crud.cy.ts
- frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/create-namespace.cy.ts
- frontend/packages/integration-tests-cypress/tests/crud/secrets/source.cy.ts
- frontend/packages/topology/integration-tests/support/commands/hooks.ts
- frontend/packages/topology/integration-tests/support/step-definitions/common/topology.ts
- frontend/packages/integration-tests-cypress/tests/crud/bulk-create-resources.cy.ts
- frontend/packages/integration-tests-cypress/tests/app/poll-console-updates.cy.ts
- frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-install-single-namespace.cy.ts
- frontend/packages/dev-console/integration-tests/support/step-definitions/customization/configure-perspectives.ts
- frontend/packages/integration-tests-cypress/support/admin.ts
- frontend/packages/topology/integration-tests/support/step-definitions/topology/workload-sidebar.ts
- frontend/packages/helm-plugin/integration-tests/support/step-definitions/common/common.ts
- frontend/packages/console-telemetry-plugin/integration-tests/support/commands/hooks.ts
- frontend/packages/webterminal-plugin/integration-tests/support/commands/hooks.ts
- frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/catalog-source-details.cy.ts
- frontend/packages/integration-tests-cypress/tests/app/filtering-and-searching.cy.ts
- frontend/packages/integration-tests-cypress/tests/crud/secrets/key-value.cy.ts
- frontend/packages/integration-tests-cypress/tests/dashboards/cluster-dashboard.cy.ts
- frontend/packages/topology/integration-tests/support/step-definitions/topology/poddisruptionbdget-warning.ts
- frontend/packages/integration-tests-cypress/tests/crud/roles-rolebindings.cy.ts
- frontend/packages/shipwright-plugin/integration-tests/support/step-definitions/common/common.ts
- frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-hub.cy.ts
- frontend/packages/integration-tests-cypress/tests/app/yaml-editor-settings.cy.ts
- frontend/packages/topology/integration-tests/support/pages/topology/topology-page.ts
- frontend/packages/dev-console/integration-tests/support/pages/app.ts
- frontend/packages/integration-tests-cypress/tests/cluster-settings/oauth.cy.ts
- frontend/packages/integration-tests-cypress/tests/crd-extensions/console-external-log-link.cy.ts
- frontend/packages/integration-tests-cypress/tests/storage/create-storage-class.cy.ts
- frontend/packages/topology/integration-tests/support/step-definitions/topology/chart-view.ts
- frontend/packages/integration-tests-cypress/tests/crud/secrets/webhook.cy.ts
- frontend/packages/integration-tests-cypress/tests/storage/clone.cy.ts
- frontend/packages/integration-tests-cypress/tests/app/start-job-from-cronjob.cy.ts
- frontend/packages/integration-tests-cypress/tests/crud/secrets/image-pull.cy.ts
- frontend/packages/dev-console/integration-tests/support/pages/functions/createGitWorkload.ts
- frontend/packages/integration-tests-cypress/tests/crud/quotas.cy.ts
- frontend/packages/knative-plugin/integration-tests/support/pages/dev-perspective/test-serverless-function-page.ts
- frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-install-global.cy.ts
- frontend/packages/knative-plugin/integration-tests/support/commands/hooks.ts
- frontend/packages/dev-console/integration-tests/support/step-definitions/common/common.ts
- frontend/packages/shipwright-plugin/integration-tests/support/commands/hooks.ts
- frontend/packages/dev-console/integration-tests/support/step-definitions/topology/create-workloads.ts
- frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-uninstall.cy.ts
- frontend/packages/dev-console/integration-tests/support/step-definitions/common/operators.ts
- frontend/packages/integration-tests-cypress/tests/app/node-terminal.cy.ts
- frontend/packages/integration-tests-cypress/tests/i18n/pseudolocalization.cy.ts
- frontend/packages/webterminal-plugin/integration-tests/support/step-definitions/web-terminal/web-terminal-adminuser.ts
- frontend/packages/dev-console/integration-tests/support/pages/functions/checkDeveloperPerspective.ts
- frontend/packages/integration-tests-cypress/tests/crud/customresourcedefinition.cy.ts
- frontend/packages/integration-tests-cypress/tests/crud/secrets/add-to-workload.cy.ts
- frontend/packages/integration-tests-cypress/tests/app/demo-dynamic-plugin.cy.ts
- frontend/packages/integration-tests-cypress/tests/favorite/favorite-option.cy.ts
- frontend/packages/integration-tests-cypress/views/guided-tour.ts
- frontend/packages/integration-tests-cypress/tests/events/events.cy.ts
- frontend/packages/integration-tests-cypress/tests/crud/environment.cy.ts
- frontend/packages/dev-console/integration-tests/support/step-definitions/health-checks/add-health-checks-topology-sidebar.ts
- frontend/packages/webterminal-plugin/integration-tests/support/step-definitions/common/webTerminal.ts
- frontend/packages/integration-tests-cypress/tests/crud/image-pull-secret.cy.ts
- frontend/packages/integration-tests-cypress/tests/app/resource-log.cy.ts
- frontend/packages/topology/integration-tests/support/step-definitions/topology/resource-quota-warning.ts
- frontend/packages/integration-tests-cypress/tests/crud/resource-crud.cy.ts
- frontend/packages/integration-tests-cypress/tests/storage/snapshot.cy.ts
- frontend/packages/integration-tests-cypress/tests/app/masthead.cy.ts
- frontend/packages/integration-tests-cypress/tests/app/overview.cy.ts
- frontend/packages/integration-tests-cypress/tests/crud/other-routes.cy.ts
- frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/deprecated-operator-warnings.cy.ts
- frontend/packages/integration-tests-cypress/tests/app/debug-pod.cy.ts
- frontend/packages/knative-plugin/integration-tests/support/step-definitions/serverless/actions-on-knative-revision.ts
- frontend/packages/knative-plugin/integration-tests/support/pages/dev-perspective/common.ts
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
frontend/packages/helm-plugin/integration-tests/cypress.config.jsfrontend/packages/console-telemetry-plugin/integration-tests/cypress.config.jsfrontend/packages/dev-console/integration-tests/cypress.config.jsfrontend/packages/topology/integration-tests/cypress.config.jsfrontend/packages/webterminal-plugin/integration-tests/cypress.config.jsfrontend/packages/console-app/src/features/integration-test.tsfrontend/packages/console-app/src/consts.tsfrontend/packages/operator-lifecycle-manager/integration-tests-cypress/cypress.config.jsfrontend/packages/dev-console/integration-tests/features/getting-started/getting-started-tour-dev-perspective.featurefrontend/packages/shipwright-plugin/integration-tests/cypress.config.jsfrontend/packages/integration-tests-cypress/cypress.config.jsfrontend/packages/knative-plugin/integration-tests/cypress.config.jsfrontend/packages/integration-tests-cypress/tests/app/auth-multiuser-login.cy.tsfrontend/packages/console-app/package.jsonfrontend/packages/integration-tests-cypress/tests/app/admission-webhook-warning-notifications.cy.tsfrontend/packages/dev-console/console-extensions.jsonfrontend/packages/console-app/console-extensions.json
🧬 Code graph analysis (1)
frontend/packages/console-app/src/features/integration-test.ts (2)
frontend/packages/console-dynamic-plugin-sdk/src/extensions/feature-flags.ts (1)
FeatureFlagHandler(46-46)frontend/packages/console-app/src/consts.ts (1)
FLAG_CYPRESS(3-3)
🔇 Additional comments (17)
frontend/packages/dev-console/integration-tests/features/getting-started/getting-started-tour-dev-perspective.feature (1)
5-5: Comment accurately documents test behaviorThe note about the automatic guided tour being disabled under Cypress explains why these scenarios are now manual-only; no issues from a test-maintainability perspective.
frontend/packages/dev-console/console-extensions.json (1)
26-33: Correctly gates dev guided tour behind CYPRESS flagAdding
flags.disallowed: ["CYPRESS"]to the dev guided-tour extension cleanly disables it in the integration-test environment while leaving normal behavior unchanged. The structure is valid and consistent with other flag usage.frontend/packages/helm-plugin/integration-tests/cypress.config.js (1)
35-52: UA configuration matches integration-test flagging approachSetting
userAgent: 'ConsoleIntegrationTestEnvironment'in the Helm e2e config is consistent with the new CYPRESS flag detection strategy and should not affect non-test environments. Please verify that theisIntegrationTestEnvironmenthandler is matching exactly this string.frontend/packages/console-telemetry-plugin/integration-tests/cypress.config.js (1)
33-51: Consistent userAgent for integration-test detectionThe added
userAgent: 'ConsoleIntegrationTestEnvironment'keeps this suite aligned with the global integration-test environment detection; no issues seen. Please confirm all Cypress integration suites use the same UA value to avoid partial behavior.frontend/packages/shipwright-plugin/integration-tests/cypress.config.js (1)
32-50: Shipwright tests correctly opt into integration-test UAUsing
userAgent: 'ConsoleIntegrationTestEnvironment'here matches the pattern used elsewhere and should reliably trigger the CYPRESS flag for these tests. Please verify this suite runs under the same Cypress version/config expectations as the others.frontend/packages/dev-console/integration-tests/cypress.config.js (1)
35-53: Dev-console Cypress config wired into integration-test UAThe added
userAgent: 'ConsoleIntegrationTestEnvironment'is essential for the CYPRESS flag to suppress the guided tour in these tests and looks correctly configured. Please confirm all prior explicit guided tour close calls in this suite have been removed and that tests pass relying solely on this flag.frontend/packages/topology/integration-tests/cypress.config.js (1)
37-55: Topology tests hooked into shared integration-test UAConfiguring
userAgent: 'ConsoleIntegrationTestEnvironment'here keeps topology tests consistent with the global integration-test detection mechanism; no issues apparent. Please double-check that any topology-specific guided tour hooks have been removed now that gating is done via the CYPRESS flag.frontend/packages/operator-lifecycle-manager/integration-tests-cypress/cypress.config.js (1)
39-39: LGTM: Clean Cypress userAgent configuration.The addition of the custom userAgent allows the integration test handler to detect when Cypress is running. The string value matches the constant used in the feature flag handler.
frontend/packages/knative-plugin/integration-tests/cypress.config.js (1)
51-51: LGTM: Consistent userAgent configuration.frontend/packages/webterminal-plugin/integration-tests/cypress.config.js (1)
51-51: LGTM: Consistent userAgent configuration.frontend/packages/integration-tests-cypress/cypress.config.js (1)
39-39: LGTM: Consistent userAgent configuration.frontend/packages/console-app/src/consts.ts (1)
3-3: LGTM: Clean constant addition.The constant follows the existing naming convention and is appropriately placed with other flag constants.
frontend/packages/console-app/package.json (1)
30-30: LGTM: Module exposure follows existing pattern.frontend/packages/console-app/console-extensions.json (2)
13-18: LGTM: Feature flag handler properly wired.The console.flag entry correctly references the handler exposed in package.json.
24-27: LGTM: Guided tour correctly disabled for Cypress.The
disallowedflag configuration ensures the guided tour won't render when the CYPRESS flag is active, which achieves the PR objective.frontend/packages/console-app/src/features/integration-test.ts (1)
6-11: Code is correct. All Cypress configuration files across the repository setuserAgent: 'ConsoleIntegrationTestEnvironment', confirming that the exact string comparison works as expected. Cypress completely replaces the userAgent string with this value.frontend/packages/integration-tests-cypress/tests/app/admission-webhook-warning-notifications.cy.ts (1)
1-167: Verify the mechanism preventing guided tours from appearing during Cypress test execution.While the integration-test feature flag is properly configured (setting
FLAG_CYPRESSbased on the Cypress userAgent 'ConsoleIntegrationTestEnvironment'), the codebase does not show a clear mechanism using this flag to disable or auto-complete guided tours during test execution. ThefilterTourBasedonPermissionAndFlag()function exists to filter tour steps by feature flags, but no tour steps are configured with theFLAG_CYPRESSrequirement, and tours are not pre-marked as completed in the test environment. Ensure the removal ofguidedTour.close()is paired with an alternative mechanism (such as marking tours as completed for Cypress or adding FLAG_CYPRESS to tour step filters) to prevent tours from interfering with test execution.
Member
Author
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
logonoff
force-pushed
the
xcx-everything-is-guided-tour
branch
2 times, most recently
from
1b89c42 to
876291f
Compare
Member
Author
|
/assign @yapei |
logonoff
force-pushed
the
xcx-everything-is-guided-tour
branch
from
876291f to
ed7e504
Compare
logonoff
force-pushed
the
xcx-everything-is-guided-tour
branch
from
ed7e504 to
ea2ec9d
Compare
Member
Author
|
Verified that guided tour no longer appears when the cypress user agent is used /verified by @logonoff |
openshift-ci-robot
added
the
verified
Contributor
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo, logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@logonoff: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
Author
|
/cherry-pick release-4.21 |
|
@logonoff: new pull request created: #15845 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
logonoff
changed the title
Contributor
|
@logonoff: Jira Issue Verification Checks: Jira Issue OCPBUGS-66045 Jira Issue OCPBUGS-66045 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully the final solution to #15829, #15776, #14928, #14866, ...