OCPBUGS-45182: add startupProbe to csi-driver
#334
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@EmilienM: This pull request references Jira Issue OCPBUGS-45182, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.18 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@EmilienM: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
approved
|
@EmilienM, |
|
/testwith openshift/hypershift/main/e2e-openstack |
|
/testwith openshift/hypershift/main/e2e-openstack-csi-manila |
EmilienM
changed the title
csi-driver-nfs under initContainers`csi-driver-nfs under initContainers`
EmilienM
changed the title
csi-driver-nfs under initContainers`
EmilienM
force-pushed
the
OCPBUGS-45182
branch
from
7efb110 to
d7688b0
Compare
|
/testwith openshift/hypershift/main/e2e-openstack |
|
/testwith openshift/hypershift/main/e2e-openstack openshift/hypershift#5202 |
assets/overlays/openstack-manila/generated/hypershift/controller.yaml
Outdated
Show resolved
Hide resolved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
The csi-driver-nfs container requires an NFS socket to be created before the csi-driver container can operate. If the socket is not available at startup, the pod will restart unnecessarily due to initialization failure. Using a postStart hook to check for the socket is not reliable, as Kubernetes does not guarantee the hook will execute before the container's entrypoint starts. This patch introduces a startupProbe to verify the existence of the NFS socket. The probe will run for up to one minute, allowing sufficient time for the socket to be created and avoiding premature pod restarts. The existing livenessProbe remains responsible for ongoing health checks.
EmilienM
force-pushed
the
OCPBUGS-45182
branch
from
d7688b0 to
73c6924
Compare
EmilienM
changed the title
csi-driver
|
@EmilienM: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The csi-driver container requires an NFS socket (handled by csi-driver-nfs) to be created before it can operate.
If the socket is not available at startup, the pod will restart unnecessarily due to initialization failure.
Using a postStart hook to check for the socket is not reliable, as Kubernetes does not guarantee the hook will execute before the container's entrypoint starts.
This patch introduces a startupProbe to verify the existence of the NFS socket.
The probe will run for up to one minute, allowing sufficient time for the socket to be created and avoiding premature pod restarts.
The existing livenessProbe remains responsible for ongoing health checks.