Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45182: Disable openstack-manila-csi-controllerplugin crash detection in e2e #5200

Closed
wants to merge 1 commit into from

Conversation

EmilienM
Copy link
Member

What this PR does / why we need it:

Whether it's on a Standalone OCP cluster or in a HostedCluster, we have a race condition
for Manila CSI with the NFS driver.
The result is openstack-manila-csi-controllerplugin crashes but eventually stabilizes after a restart.
We will solve the race condition.
For now we need to disable crash detection of openstack-manila-csi-controllerplugin to unblock the presubmit jobs.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 28, 2024
@openshift-ci-robot
Copy link

@EmilienM: This pull request references Jira Issue OCPBUGS-45182, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

Whether it's on a Standalone OCP cluster or in a HostedCluster, we have a race condition
for Manila CSI with the NFS driver.
The result is openstack-manila-csi-controllerplugin crashes but eventually stabilizes after a restart.
We will solve the race condition.
For now we need to disable crash detection of openstack-manila-csi-controllerplugin to unblock the presubmit jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and hasueki November 28, 2024 20:13
@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Nov 28, 2024
@EmilienM
Copy link
Member Author

/test e2e-openstack

@EmilienM
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@EmilienM: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…tection in e2e

Whether it's on a Standalone OCP cluster or in a HostedCluster, we have a race condition
for Manila CSI with the NFS driver.
The result is openstack-manila-csi-controllerplugin crashes but eventually stabilizes after a restart.
We will solve the race condition.
For now we need to disable crash detection of openstack-manila-csi-controllerplugin to unblock the presubmit jobs.
@EmilienM
Copy link
Member Author

/test e2e-openstack

@EmilienM
Copy link
Member Author

/hold
we might fix it here: openshift/csi-operator#334

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2024
@EmilienM
Copy link
Member Author

/testwith openshift/hypershift/main/e2e-openstack #5202

@EmilienM
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2024
@jparrill
Copy link
Contributor

/approve
/retest

Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@EmilienM
Copy link
Member Author

/hold
still testing a fix in csi-operator...

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2024
@EmilienM
Copy link
Member Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Nov 30, 2024

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack cee9cf8 link false /test e2e-openstack
ci/prow/okd-scos-e2e-aws-ovn cee9cf8 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-4-17 cee9cf8 link true /test e2e-aws-4-17
ci/prow/e2e-aws-4-18 cee9cf8 link true /test e2e-aws-4-18

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member Author

EmilienM commented Dec 2, 2024

We didn't come up with a proper fix in CSI operator but we realise that we might have more work to do on this one, so for now let's just tolerate the restart. We'll provide a cleaner fix in 4.19.
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024
@EmilienM
Copy link
Member Author

EmilienM commented Dec 2, 2024

/close
I'll combine this fix into #5202

@openshift-ci openshift-ci bot closed this Dec 2, 2024
Copy link
Contributor

openshift-ci bot commented Dec 2, 2024

@EmilienM: Closed this PR.

In response to this:

/close
I'll combine this fix into #5202

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

@EmilienM: This pull request references Jira Issue OCPBUGS-45182. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

Whether it's on a Standalone OCP cluster or in a HostedCluster, we have a race condition
for Manila CSI with the NFS driver.
The result is openstack-manila-csi-controllerplugin crashes but eventually stabilizes after a restart.
We will solve the race condition.
For now we need to disable crash detection of openstack-manila-csi-controllerplugin to unblock the presubmit jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM EmilienM deleted the OCPBUGS-45182 branch December 2, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants