-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1950026: Sync with upstream #62
bug 1950026: Sync with upstream #62
Conversation
…time PodLifetime is simpler in validating results
…edicates-cleanup code cleanup: remove check on length
Invert main strategy loop for performance and customizability
Always use structured logging. Therefore update klog.Errorf() to instead use klog.ErrorS(). Here is an example of the new log message. E0428 23:58:57.048912 586 descheduler.go:145] "skipping strategy" err="unknown strategy name" strategy=ASDFPodLifeTime
…d-logging Use Structured Logging For Unknown Strategy Log Message
…ages Update error messages in verify scripts to be more informative
Add test cases for soft constraints/multi constraints
…tion RemovePodsViolatingTopologySpreadConstraint : Take node's taints into consideration when balancing domains
…heduler-descheduler_test-fix-errorhandling Add verify script for govet & fix pkg/descheduler/descheduler_test.go
…nto account when computing a number of feasible nodes for the average occurence of pods per node Nodes with taints which are not tolerated by evicted pods will never run the pods. The same holds for node affinity and node selector. So increase the number of pods per feasible nodes to decrease the number of evicted pods.
This is required for running e2e tests for k8s v1.21.
…-version Bump kind version
@ingvagabund: This pull request references Bugzilla bug 1950026, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@ingvagabund: This pull request references Bugzilla bug 1950026, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
61fc364
to
00c1931
Compare
@ingvagabund: This pull request references Bugzilla bug 1950026. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ingvagabund: This pull request references Bugzilla bug 1950026, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
@ingvagabund: An error was encountered checking the state of a related pull request at kubernetes-sigs#563 for bug 1950026 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Get "http://ghproxy/repos/kubernetes-sigs/descheduler/pulls/563": failed to get installation id for org kubernetes-sigs: the github app is not installed in organization kubernetes-sigs
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@ingvagabund: An error was encountered checking the state of a related pull request at kubernetes-sigs#563 for bug 1950026 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Get "http://ghproxy/repos/kubernetes-sigs/descheduler/pulls/563": failed to get installation id for org kubernetes-sigs: the github app is not installed in organization kubernetes-sigs
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build atomic-openshift-descheduler-container-v4.8.0-202311261141.p0.g37691a4.assembly.stream for distgit atomic-openshift-descheduler. |
SSIA