Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1950026: Sync with upstream #62

Merged
merged 51 commits into from
Jun 10, 2021

Conversation

ingvagabund
Copy link
Member

SSIA

pravarag and others added 30 commits April 14, 2021 10:29
…time

PodLifetime is simpler in validating results
…edicates-cleanup

code cleanup: remove check on length
Invert main strategy loop for performance and customizability
Always use structured logging. Therefore update klog.Errorf() to instead
use klog.ErrorS().

Here is an example of the new log message.

E0428 23:58:57.048912 586 descheduler.go:145] "skipping strategy" err="unknown strategy name" strategy=ASDFPodLifeTime
…d-logging

Use Structured Logging For Unknown Strategy Log Message
…ages

Update error messages in verify scripts to be more informative
Add test cases for soft constraints/multi constraints
…tion

RemovePodsViolatingTopologySpreadConstraint : Take node's taints into consideration when balancing domains
…heduler-descheduler_test-fix-errorhandling

Add verify script for govet & fix pkg/descheduler/descheduler_test.go
…nto account when computing a number of feasible nodes for the average occurence of pods per node

Nodes with taints which are not tolerated by evicted pods will never run the
pods. The same holds for node affinity and node selector.
So increase the number of pods per feasible nodes to decrease the
number of evicted pods.
This is required for running e2e tests for k8s v1.21.
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2021

@ingvagabund: This pull request references Bugzilla bug 1950026, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 1950026: Sync with upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 9, 2021
@openshift-ci openshift-ci bot requested review from damemi and soltysh June 9, 2021 10:39
@ingvagabund
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 9, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2021

@ingvagabund: This pull request references Bugzilla bug 1950026, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from kasturinarra June 9, 2021 10:40
Copy link

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 9, 2021
@ingvagabund ingvagabund force-pushed the sync-with-upstream branch 2 times, most recently from 61fc364 to 00c1931 Compare June 9, 2021 14:23
@openshift-ci
Copy link

openshift-ci bot commented Jun 10, 2021

@ingvagabund: This pull request references Bugzilla bug 1950026. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

bug 1950026: Sync with upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund reopened this Jun 10, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 10, 2021

@ingvagabund: This pull request references Bugzilla bug 1950026, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

bug 1950026: Sync with upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member Author

/retest

@damemi
Copy link

damemi commented Jun 10, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 37691a4 into openshift:master Jun 10, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 10, 2021

@ingvagabund: An error was encountered checking the state of a related pull request at kubernetes-sigs#563 for bug 1950026 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Get "http://ghproxy/repos/kubernetes-sigs/descheduler/pulls/563": failed to get installation id for org kubernetes-sigs: the github app is not installed in organization kubernetes-sigs

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

bug 1950026: Sync with upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the sync-with-upstream branch June 10, 2021 12:49
@ingvagabund
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jun 10, 2021

@ingvagabund: An error was encountered checking the state of a related pull request at kubernetes-sigs#563 for bug 1950026 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Get "http://ghproxy/repos/kubernetes-sigs/descheduler/pulls/563": failed to get installation id for org kubernetes-sigs: the github app is not installed in organization kubernetes-sigs

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build atomic-openshift-descheduler-container-v4.8.0-202311261141.p0.g37691a4.assembly.stream for distgit atomic-openshift-descheduler.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.