Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2017752: Anonymize identity provider attributes in the #520

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Bug 2017752: Anonymize identity provider attributes in the #520

merged 2 commits into from
Oct 27, 2021

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Oct 15, 2021

authentication.operator.openshift.io definition

This PR implements a new data enhancement to...

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No new data

Documentation

No doc update

Unit Tests

No new test

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@tremes
Anonymize identity provider attributes in the
62474fc 
authentication.operator.openshift.io definition
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2021
@tremes tremes changed the title WIP Anonymize identity provider attributes in the Anonymize identity provider attributes in the Oct 18, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2021
natiiix
natiiix approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested the changes locally, but they seem relatively simple and straight-forward. It should not break the rest of the operator even if it didn't work exactly as intended.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@tremes tremes changed the title Anonymize identity provider attributes in the Bug 2017752: Anonymize identity provider attributes in the Oct 27, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Oct 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2021

@tremes: This pull request references Bugzilla bug 2017752, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

Bug 2017752: Anonymize identity provider attributes in the

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 27, 2021
@tremes
Copy link
Contributor Author

tremes commented Oct 27, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2021

@tremes: This pull request references Bugzilla bug 2017752, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 04360d3 into openshift:master Oct 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2021

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 2017752 has been moved to the MODIFIED state.

In response to this:

Bug 2017752: Anonymize identity provider attributes in the

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes added a commit to tremes/insights-operator that referenced this pull request Oct 27, 2021
@tremes
[release-4.9] Bug 2017773: Anonymize identity provider attributes in …
e4c429b 
…the (openshift#520)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
@tremes tremes mentioned this pull request Oct 27, 2021
Merged
4 tasks
openshift-merge-robot pushed a commit that referenced this pull request Nov 9, 2021
@tremes
[release-4.9] Bug 2017773: Anonymize identity provider attributes in …
dd4d72c 
…the (#520) (#527)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/insights-operator that referenced this pull request Nov 9, 2021
@tremes
Bug 2017773: Anonymize identity provider attributes in the (openshift…
ed9b22c 
…#520)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
tremes added a commit to tremes/insights-operator that referenced this pull request Nov 10, 2021
@tremes
[release-4.8] Bug 2021572: Anonymize identity provider attributes in …
b808844 
…the (openshift#520) (openshift#527)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
@tremes tremes mentioned this pull request Nov 10, 2021
Merged
4 tasks
openshift-merge-robot pushed a commit that referenced this pull request Nov 18, 2021
@tremes
[release-4.8] Bug 2021572: Anonymize identity provider attributes in …
44ea072 
…the (#520) (#527) (#541)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
tremes added a commit to tremes/insights-operator that referenced this pull request Nov 18, 2021
@tremes
[release-4.7] Bug 2024614: Anonymize identity provider attributes in …
0ba1ff5 
…the (openshift#520) (openshift#527) (openshift#541)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
@tremes tremes mentioned this pull request Nov 18, 2021
Merged
4 tasks
openshift-merge-robot pushed a commit that referenced this pull request Nov 22, 2021
@tremes
[release-4.7] Bug 2024614: Anonymize identity provider attributes in …
6258ceb 
…the (#520) (#527) (#541) (#549)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
@tremes tremes deleted the idp_anonymization branch May 6, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natiiix natiiix natiiix approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@natiiix natiiix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremes @openshift-bot @natiiix @openshift-merge-robot