-
Notifications
You must be signed in to change notification settings - Fork 243
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
odo create --s2i flag shows Warning message on 4.6 cluster #4016
Comments
So, I dug little bit more into the issue and the point of hitting Logs: Creating component on 4.6 cluster and image description
Creating component on 4.5 cluster and image description
@kadel @girishramnani Should we add the latest image pointed in 4.6 as supported? Please let me know your suggestions. |
yes, we need to test odo with |
I have tested odo with some of the command on nodejs image Commands verified on image
Devfile registry and s2i commands also works fine. |
@prietyc123 what you did is not correct and you are not testing You need to use The important part is to test that debugging with this image works. hint: For debug to work with s2i component and this new image you will have to use new init image container with changes in https://github.com/openshift/odo-init-image/pull/72/files |
@kadel Though I have not mentioned all the commands that I verifies. Yes, For s2i I have used |
Would it add value if there was a script that would test the various scenarios automatically for a provided image name? For example, $ script.sh --s2i nodejs some.registry.io/nodejs:sometag
$ script.sh --s2i java some.registry.io/some-java-framework:sometag
$ script.sh --devfile nodejs some.registry.io/nodejs:sometag
$ script.sh --devfile java some.registry.io/some-java-framework:sometag I'm asking this because if I understand correctly, we are soon going to focus on growing odo horizontally (add support for more frameworks) than just growing it vertically (adding more features.) WDYT @kadel ? EDIT: I don't meant to add it as a part of this PR. It should be a separate task if we think it's worth spending time doing it. |
and debugiung worked with ubi8/nodejs-12 and default init image ? |
The problem that those commands are completely unrelated to this issue. When you are using this sequence of commands it doesn't use s2i builder images. So you can't say that you tested
I see the same confusing as with Priti's comment. Devfile components doesn't use s2i builder images. |
Ah. This is likely a better question for the devfile-registry repo? My intention here is for us to be able to have a framework that would make adding support for new component types easier and more automated. |
AFAIU I have added the image |
Tests for Detailed failure log: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4070/pull-ci-openshift-odo-master-v4.5-integration-e2e/1323912242453811200#1:build-log.txt%3A1405 |
/kind bug
What versions of software are you using?
Operating System:
All supported
Output of
odo version
:master
How did you run odo exactly?
Steps:
However there is no warning message reflects on 4.5
Actual behavior
Shows warning message
Warning: nodejs is not fully supported by odo, and it is not guaranteed to work
on 4.6Expected behavior
Functionality of component create should not depend on cluster.
Any logs, error output, etc?
The text was updated successfully, but these errors were encountered: