fix: remove requirement for URL to end with .zip #3854
Conversation
openshift-ci-robot
added
the
kind/bug
| @@ -904,9 +904,6 @@ func GetAndExtractZip(zipURL string, destination string, pathToUnzip string) err | |||
| if zipURL == "" { | |||
| return errors.Errorf("Empty zip url: %s", zipURL) | |||
| } | |||
| if !strings.Contains(zipURL, ".zip") { | |||
| return errors.Errorf("Invalid zip url: %s", zipURL) | |||
| } | |||
|
|
|||
| var pathToZip string | |||
| if strings.HasPrefix(zipURL, "file://") { | |||
There was a problem hiding this comment.
I am ok with this PR but do we want to also enforce that the url starts with file:// a url could be a simple http or https one but could have a zip file returned?
There was a problem hiding this comment.
You're missing the rest of the code which deals with that… 😉
|
platform issue |
|
small fix |
openshift-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #3854 +/- ##
=======================================
Coverage 44.19% 44.19%
=======================================
Files 141 141
Lines 13600 13598 -2
=======================================
Hits 6010 6010
+ Misses 7007 7005 -2
Partials 583 583
Continue to review full report at Codecov.
|
What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
Fixes #3853