Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HACDOCS-698: Updated the content for the Enhanced PipelineRun details view in the Web Console #70231

Merged
merged 1 commit into from
Feb 16, 2024
Merged

HACDOCS-698: Updated the content for the Enhanced PipelineRun details view in the Web Console #70231

merged 1 commit into from
Feb 16, 2024

Conversation

gtrivedi88
Copy link
Contributor

@gtrivedi88 gtrivedi88 commented Jan 15, 2024 •
edited
Loading

Purpose: To resolve HACDOCS-698

Aligned team: DevTools

Version for cherrypicking: pipelines-docs-1.12, pipelines-docs-1.13, pipelines-docs-1.14

Content for preview: https://70231--docspreview.netlify.app/openshift-pipelines/latest/secure/setting-up-openshift-pipelines-to-view-software-supply-chain-security-elements

SME review: @rohitkrai03 @karthikjeeyar @vdemeester

QE review: @ppitonak

Peer review:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2024 •
edited by openshift-ci bot
Loading

@gtrivedi88: This pull request references HACDOCS-698 which is a valid jira issue.

In response to this:

Purpose: To resolve HACDOCS-698

Aligned team: DevTools

Version for cherrypicking: pipelines-docs 1.1

Content for preview:

SME review: @rohitkrai03 @karthikjeeyar @vdemeester

QE review: @ppitonak

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 15, 2024

Hi @gtrivedi88. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 15, 2024 •
edited
Loading

🤖 Updated build preview is available at:
https://70231--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37523

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2024 •
edited by openshift-ci bot
Loading

@gtrivedi88: This pull request references HACDOCS-698 which is a valid jira issue.

In response to this:

Purpose: To resolve HACDOCS-698

Aligned team: DevTools

Version for cherrypicking: pipelines-docs 1.1

Content for preview: https://70231--docspreview.netlify.app/openshift-pipelines/latest/create/working-with-pipelines-web-console#op-enhanced-pipelinerun-details-view-web-console_working-with-pipelines-web-console

SME review: @rohitkrai03 @karthikjeeyar @vdemeester

QE review: @ppitonak

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

karthikjeeyar
karthikjeeyar reviewed Jan 15, 2024
View reviewed changes
modules/op-viewing-and-downloading-sboms.adoc Outdated Show resolved Hide resolved
modules/op-viewing-and-downloading-sboms.adoc Outdated Show resolved Hide resolved
modules/op-viewing-and-downloading-sboms.adoc Outdated Show resolved Hide resolved
modules/op-viewing-and-downloading-sboms.adoc Outdated Show resolved Hide resolved
@gtrivedi88 gtrivedi88 force-pushed the HACDOCS-713 branch 2 times, most recently from 558b02f to 8725fd4 Compare January 17, 2024 08:29
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot
Loading

@gtrivedi88: This pull request references HACDOCS-698 which is a valid jira issue.

In response to this:

Purpose: To resolve HACDOCS-698

Aligned team: DevTools

Version for cherrypicking: pipelines-docs 1.1

Content for preview: https://70231--docspreview.netlify.app/openshift-pipelines/latest/secure/setting-up-openshift-pipelines-to-view-software-supply-chain-security-elements

SME review: @rohitkrai03 @karthikjeeyar @vdemeester

QE review: @ppitonak

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@karthikjeeyar
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
@gtrivedi88
Copy link
Contributor Author

@ppitonak Addressed your comments. Could you please review and let me know your suggestions or LGTM?
Thank you!

mramendi
mramendi reviewed Feb 3, 2024
View reviewed changes
Copy link
Contributor

@mramendi mramendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the structure now! Added peer review style comments.

modules/op-setting-up-openshift-pipelines-to-download-or-view-sboms.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-download-or-view-sboms.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-download-or-view-sboms.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-download-or-view-sboms.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-download-or-view-sboms.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-view-project-vulnerabilities.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-view-project-vulnerabilities.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-view-project-vulnerabilities.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-view-project-vulnerabilities.adoc Outdated Show resolved Hide resolved
secure/setting-up-openshift-pipelines-to-view-software-supply-chain-security-elements.adoc Outdated Show resolved Hide resolved
ppitonak
ppitonak approved these changes Feb 7, 2024
View reviewed changes
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

modules/op-setting-up-openshift-pipelines-to-download-or-view-sboms.adoc Outdated Show resolved Hide resolved
mramendi
mramendi reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@mramendi mramendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nits but it's all good in general

modules/op-setting-up-openshift-pipelines-to-download-or-view-sboms.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-download-or-view-sboms.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-download-or-view-sboms.adoc Outdated Show resolved Hide resolved
modules/op-setting-up-openshift-pipelines-to-download-or-view-sboms.adoc Outdated Show resolved Hide resolved
secure/setting-up-openshift-pipelines-to-view-software-supply-chain-security-elements.adoc Outdated Show resolved Hide resolved
secure/setting-up-openshift-pipelines-to-view-software-supply-chain-security-elements.adoc Outdated Show resolved Hide resolved
@dfitzmau dfitzmau mentioned this pull request Feb 9, 2024
Merged
1 task
mramendi
mramendi approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@mramendi mramendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one slight style nit, please fix if possible. Approved, no need for further reviews. I might add an additional resources link specifically to the pipelinerun details page if I manage to split it off into a module

secure/setting-up-openshift-pipelines-to-view-software-supply-chain-security-elements.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 14, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 15, 2024

New changes are detected. LGTM label has been removed.

@mramendi
Copy link
Contributor

ok to test

@mramendi
Copy link
Contributor

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 15, 2024
@ShaunaDiaz
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2024
@ShaunaDiaz
Copy link
Contributor

@gtrivedi88 You'll have to rebase to get this to test with Prow, which we are using now. Also, the <.> syntax for footnotes does not resolve on the Customer Portal. Footnotes have to be set manually with numbering.

@ShaunaDiaz
Copy link
Contributor

/remove-label merge-review-needed

@ShaunaDiaz
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 15, 2024
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Feb 16, 2024
@ShaunaDiaz ShaunaDiaz merged commit 0333872 into openshift:pipelines-docs Feb 16, 2024
1 check passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick pipelines-docs-1.12

@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #71725

In response to this:

/cherrypick pipelines-docs-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 16, 2024
Merged
@ShaunaDiaz
Copy link
Contributor

/cherrypick pipelines-docs-1.13

@ShaunaDiaz
Copy link
Contributor

/cherrypick pipelines-docs-1.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 16, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #71726

In response to this:

/cherrypick pipelines-docs-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #71727

In response to this:

/cherrypick pipelines-docs-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@mramendi mramendi mramendi approved these changes

@karthikjeeyar karthikjeeyar karthikjeeyar approved these changes

@ppitonak ppitonak ppitonak approved these changes

Assignees

@karthikjeeyar karthikjeeyar

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR pipelines size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@gtrivedi88 @openshift-ci-robot @ocpdocs-previewbot @karthikjeeyar @mramendi @GroceryBoyJr @ShaunaDiaz @openshift-cherrypick-robot @ppitonak