Fail fast on setup failure #1956
Conversation
If cluster setup fails, touch the shared exit signal file immediately. Otherwise the pod won't fail for hours.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ironcladlou If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
size/XS
| @@ -241,6 +241,9 @@ objects: | |||
| #!/bin/sh | |||
| export _CI_ONLY_STAY_AWAY_OPENSHIFT_INSTALL_AWS_USER_TAGS="{\"expirationDate\": \"$(date -d '4 hours' --iso=minutes --utc)\"}" | |||
| exec /bin/openshift-install --dir=/tmp/artifacts/installer --log-level=debug cluster | |||
| if [ $? -ne 0 ]; then | |||
| touch /tmp/shared/exit | |||
| fi | |||
There was a problem hiding this comment.
We still want this shell script to exit non-zero on failures. How about we restore the line I removed here when trying to drop the shell from the setup container (which we backed away from in #1761). But with [ instead of [[ because we're no longer Bash (or change the shebang to make this script Bash again as well).
There was a problem hiding this comment.
While we're at it, we probably want to restore the TERM handler too.
There was a problem hiding this comment.
That sounds more robust... I'm out of time today, so I'll close this PR and either re-open with your fix or leave it close in favor of a replacement from you- whichever comes first. Thanks!
If cluster setup fails, touch the shared exit signal file immediately. Otherwise
the pod won't fail for hours.