Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast on setup failure #1956

Closed
wants to merge 1 commit into from
Closed

Fail fast on setup failure #1956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ objects:
#!/bin/sh
export _CI_ONLY_STAY_AWAY_OPENSHIFT_INSTALL_AWS_USER_TAGS="{\"expirationDate\": \"$(date -d '4 hours' --iso=minutes --utc)\"}"
exec /bin/openshift-install --dir=/tmp/artifacts/installer --log-level=debug cluster
if [ $? -ne 0 ]; then
touch /tmp/shared/exit
fi
Copy link
Member

@wking wking Oct 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want this shell script to exit non-zero on failures. How about we restore the line I removed here when trying to drop the shell from the setup container (which we backed away from in #1761). But with [ instead of [[ because we're no longer Bash (or change the shebang to make this script Bash again as well).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, we probably want to restore the TERM handler too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds more robust... I'm out of time today, so I'll close this PR and either re-open with your fix or leave it close in favor of a replacement from you- whichever comes first. Thanks!


# Performs cleanup of all created resources
- name: teardown
Expand Down