Skip to content

Conversation

@sunzhaohua2
Copy link
Contributor

@sunzhaohua2 sunzhaohua2 commented Oct 23, 2025

Similar to pr #65424 update image tags.
@huali9 @miyadav @damdo PTAL, thanks!

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2025

@sunzhaohua2: This pull request references OCPCLOUD-3209 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

…tags

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2025

@sunzhaohua2: This pull request references OCPCLOUD-3209 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2025

@sunzhaohua2: This pull request references OCPCLOUD-3209 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Similar to pr #65424 update image tags.
@huali9 @miyadav @damdo PTAL, thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@miyadav
Copy link
Member

miyadav commented Oct 24, 2025

/lgtm

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@sunzhaohua2: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-azure-release-4.21-e2e-azure openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-e2e-azure-capi-techpreview openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-e2e-azure-manual-oidc openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-e2e-azure-serial-1of2 openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-e2e-azure-serial-2of2 openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-e2e-azure-techpreview openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-e2e-azurestack-ipi openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-hypershift-e2e-aks openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-images openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-regression-clusterinfra-azure-ipi-techpreview-capi openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-unit openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-verify-commits openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-verify-deps openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-e2e-azure openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-e2e-azure-capi-techpreview openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-e2e-azure-manual-oidc openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-e2e-azure-serial-1of2 openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-e2e-azure-serial-2of2 openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-e2e-azure-techpreview openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-e2e-azurestack-ipi openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-hypershift-e2e-aks openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-images openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-regression-clusterinfra-azure-ipi-techpreview-capi openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-unit openshift/cluster-api-provider-azure presubmit Ci-operator config changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-verify-commits openshift/cluster-api-provider-azure presubmit Ci-operator config changed

A total of 1285 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@damdo
Copy link
Member

damdo commented Oct 27, 2025

/assign @elmiko

For the KCA approval

@damdo
Copy link
Member

damdo commented Oct 29, 2025

/assign @JoelSpeed

For KCA approval

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick question, i'm guessing it's ok for the 4.22 files to have tag: "4.21" in them?

@elmiko
Copy link
Contributor

elmiko commented Oct 29, 2025

i chatted with Damiano about the version stuff, i'm clear now.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2025
@huali9
Copy link
Contributor

huali9 commented Oct 30, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, elmiko, huali9, miyadav, sunzhaohua2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunzhaohua2
Copy link
Contributor Author

/rehearsals-ack

@sunzhaohua2
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@sunzhaohua2: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

@sunzhaohua2: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bcb8702 into openshift:master Oct 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants