-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept osm ids in the relation member / membership dropdowns #3487
Comments
Thinking about this more.. We already support in the search box:
That box should recognize osm ids too. |
It does already, if you prefix the ID with |
Nice! I didn't know that. Thought about it more and realized that this doesn't actually address the original issue - adding a member to a relation by typing in the relation id. Probably not impossible, but would involve tricky stuff in d3combo. |
I'd agree, that this is insufficient.
This doesn't seem to be the real user requirement, but just the request for a dirty workaround.
The source of such a paste operation could just be a normal Ctrl-C copy from the map. In addition being able to copy from the members section of another relation would have some other usecases. |
Potlatch 2 has a text field that accepts a relation ID, but it also keeps loaded relations in the list for the entire editing session, which mitigates the need for this text field: #3622. |
A workaround that allows you to add a feature to a relation that is offscreen in iD:
|
See #3622 for a proposed solution. |
I added the ability to filter the relation list by ID, but this still doesn't let you add to a relation that's not in the nearby list. Are we sure we want to enable that behavior? I can imagine scenarios where users type the wrong ID and accidentally connect to relations thousands of miles away. |
I made it so you can specify IDs of loaded relations. This is simpler and safer than trying to fetch arbitrary relations for any ID a user types. |
@quincylvania
Currently the real usecases aren't supported. |
Those sound like very rare cases. The first case doesn't seem possible... unloaded? The second seems quite difficult as well, since iD can only know if something is in the viewport if it's downloaded. |
@BjornRasmussen
iD doesn't keep all the downloaded data when panning to a different location.
iD has two options here:
|
Entities don't get unloaded once loaded. You can easily start in California then navigate to Hawaii. California will still be loaded and available to reference as a relation.
This is essentially the same as the ability to connect to any relation in OSM, since the user could zoom all the way out so the whole world is in the viewport. This seems like an easy way to make mistakes without many added benefits. |
I came to this issue via this question and #1906. I am trying to add a section to the Schuylkill River Trail relation. This trail is only partially complete and I am looking to add a section which is in between a big gap. I can't get the desired relation to show up in the the add relation menu in iD. Have tried some of the methods of moving the viewport and zooming in and out to no avail. Would be really nice to be able to add by relation id, perhaps requiring some sort of extra confirmation. I've also hit this problem while editing the Long Trail relation. Understand that it's important to avoid spurious relations, but currently it seems like there is major missing functionality in terms of way relations that are not entirely contiguous (like many long distance trails). Update: I used the workaround to create a temporary connecting way with the desired relation that's described in #3487 (comment). This was a dirty workaround and opened up lot's of opportunity to make inadvertent edits. |
See my post in #3622 for a proposed solution. My fork of ID at www.wanderreitkarte.de would allow you to fill the gap easily. However, you would need to set the coordinates in the URL to navigate there as my map does not cover the US. |
@dhimmel If the relation is already downloaded, then you can now type the exact ID to get it to show up in the dropdown. |
Currently the list of suggested relations contains only the ones which are quite near the object you are editing. It would be nice to have an ability to select a relation by id.
The text was updated successfully, but these errors were encountered: